Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 392983003: Add a workaround for broken adb get-state call. (Closed)

Created:
6 years, 5 months ago by aurimas (slooooooooow)
Modified:
6 years, 5 months ago
Reviewers:
cjhopman, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a workaround for broken adb get-state call. adb get-state is broken in Android L. Add a temporary workaround so we can keep using managed_install while it is getting fixed. Internal bug b/15881946 BUG=394042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M build/android/pylib/android_commands.py View 1 chunk +9 lines, -2 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aurimas (slooooooooow)
cjhopman and jbudorick PTAL
6 years, 5 months ago (2014-07-15 18:55:40 UTC) #1
jbudorick
lgtm
6 years, 5 months ago (2014-07-15 20:04:05 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 5 months ago (2014-07-15 20:04:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/392983003/1
6 years, 5 months ago (2014-07-15 20:08:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 04:12:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 04:49:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171043)
6 years, 5 months ago (2014-07-16 04:49:13 UTC) #7
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 5 months ago (2014-07-16 05:23:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/392983003/1
6 years, 5 months ago (2014-07-16 05:28:04 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 06:20:46 UTC) #10
Message was sent while issue was closed.
Change committed as 283375

Powered by Google App Engine
This is Rietveld 408576698