WebKit merge 41447:41498

WebKit merge 41447:41498


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11210

[eroman, 2009-03-07 00:30:18]

The rebaselined tests are to account for the change to editing from
<http://trac.webkit.org/changeset/41465>

(I have deferred the re-basing on linux as a post step, for my convenience).

The video change is to match the refactoring made by:
<http://trac.webkit.org/changeset/41486>
Which changes setRect(Rect) --> setSize(Size).

I propogated this change to WebMediaPlayerDelegate[Impl], however I didn't touch
the VideoRenderImpl::SetRect() API. Since it is a no-op right now, nothing
should get broken by this. However someone familiar with that class should take
a look for final resolution. (I've left a TODO for now).

http://codereview.chromium.org/39297/diff/1/46
File chrome/renderer/webmediaplayer_delegate_impl.cc (right):

http://codereview.chromium.org/39297/diff/1/46#newcode262
Line 262: // TODO(eroman): What to do here?
VideoRendererImpl::SetRect() is a no-op, so this doesn't affect anything right
now ....

[darin (slow to review), 2009-03-07 00:38:44]

LGTM

[eroman, 2009-03-07 00:42:52]

Updated (had forgotten to add tests_fixable.txt to the CL).

(I added the rebased tests as expected fail under Linux, since I rebased on
windows only so far).

[scherkus (not reviewing), 2009-03-07 01:39:58]

thanks for noticing this!

http://codereview.chromium.org/39297/diff/95/1094
File chrome/renderer/webmediaplayer_delegate_impl.cc (right):

http://codereview.chromium.org/39297/diff/95/1094#newcode263
Line 263: video_renderer_->SetRect(gfx::Rect(0, 0, size.width(),
size.height()));
Technically, we have to go in and change our stuff to use SetSize as well, but
this code will still work the same way.

You can put a TODO(scherkus) and we'll fix it later.