Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 392943002: Fix Handle above IME issue (Closed)

Created:
6 years, 5 months ago by AviD
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, AKVT, Cyan, ankit, kangil_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Handle above IME issue Added flag to check if IME state is updated This will prevent resetting of mFocusPreOSKViewportRect on onTouchEvent. So, if cancelRequestToScrollFocusedEditableNodeIntoView() is triggerred from onTouchEvent()<ACTION_MOVE> and it happens before onSizeChanged is triggerred, then the input field will not be scrolled to view. BUG=393948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283434

Patch Set 1 #

Total comments: 2

Patch Set 2 : Calling cancelRequestToScrollFocusedEditableNodeIntoView only on ACTION_DOWN #

Patch Set 3 : rebase to latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
AviD
PTAL
6 years, 5 months ago (2014-07-15 14:51:21 UTC) #1
jdduke (slow)
https://codereview.chromium.org/392943002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/392943002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1135 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1135: cancelRequestToScrollFocusedEditableNodeIntoView(); I think we can achieve the same result ...
6 years, 5 months ago (2014-07-15 15:36:58 UTC) #2
AviD
Uploaded new patch. PTAL https://codereview.chromium.org/392943002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/392943002/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1135 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1135: cancelRequestToScrollFocusedEditableNodeIntoView(); Agree. It was my ...
6 years, 5 months ago (2014-07-15 15:58:02 UTC) #3
jdduke (slow)
lgtm
6 years, 5 months ago (2014-07-15 16:01:02 UTC) #4
AviD
The CQ bit was checked by avi.nitk@samsung.com
6 years, 5 months ago (2014-07-15 16:01:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/20001
6 years, 5 months ago (2014-07-15 16:03:13 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 00:58:30 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 01:06:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170933) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/39244)
6 years, 5 months ago (2014-07-16 01:06:39 UTC) #9
AviD
The CQ bit was checked by avi.nitk@samsung.com
6 years, 5 months ago (2014-07-16 02:24:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/20001
6 years, 5 months ago (2014-07-16 02:28:32 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 02:42:00 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 02:46:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170933)
6 years, 5 months ago (2014-07-16 02:46:08 UTC) #14
AviD
The CQ bit was checked by avi.nitk@samsung.com
6 years, 5 months ago (2014-07-16 05:13:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/40001
6 years, 5 months ago (2014-07-16 05:17:51 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 11:39:12 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 11:58:43 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171408)
6 years, 5 months ago (2014-07-16 11:58:44 UTC) #19
AviD
The CQ bit was checked by avi.nitk@samsung.com
6 years, 5 months ago (2014-07-16 15:07:12 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/40001
6 years, 5 months ago (2014-07-16 15:09:46 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:19:25 UTC) #22
Message was sent while issue was closed.
Change committed as 283434

Powered by Google App Engine
This is Rietveld 408576698