|
|
Chromium Code Reviews
DescriptionFix Handle above IME issue
Added flag to check if IME state is updated
This will prevent resetting of mFocusPreOSKViewportRect
on onTouchEvent.
So, if cancelRequestToScrollFocusedEditableNodeIntoView()
is triggerred from onTouchEvent()<ACTION_MOVE> and it
happens before onSizeChanged is triggerred, then the
input field will not be scrolled to view.
BUG=393948
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283434
Patch Set 1 #
Total comments: 2
Patch Set 2 : Calling cancelRequestToScrollFocusedEditableNodeIntoView only on ACTION_DOWN #Patch Set 3 : rebase to latest #Messages
Total messages: 22 (0 generated)
PTAL
https://codereview.chromium.org/392943002/diff/1/content/public/android/java/... File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/392943002/diff/1/content/public/android/java/... content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1135: cancelRequestToScrollFocusedEditableNodeIntoView(); I think we can achieve the same result by simply moving this command below |final int eventAction = event.getActionMasked();|, and then calling it like: if (eventAction == MotionEvent.ACTION_DOWN) { cancelRequestToScrollFocusedEditableNodeIntoView(); } While it might result in the scroll after longpress being interrupted by the focus call, it's somewhat simpler than the additional logic bit.
Uploaded new patch. PTAL https://codereview.chromium.org/392943002/diff/1/content/public/android/java/... File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/392943002/diff/1/content/public/android/java/... content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1135: cancelRequestToScrollFocusedEditableNodeIntoView(); Agree. It was my initial thought, but wasn't sure of the side effects it might cause. Will change to this.
lgtm
The CQ bit was checked by avi.nitk@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was checked by avi.nitk@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by avi.nitk@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was checked by avi.nitk@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/392943002/40001
Message was sent while issue was closed.
Change committed as 283434 |
