Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: runtime/vm/report_test.cc

Issue 392933003: vm/observatory: Clean up script access (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/report_test.cc
diff --git a/runtime/vm/report_test.cc b/runtime/vm/report_test.cc
index ba66a9a565fcfbad55b43d3bc57febdf36bc6c8b..88b6839ce866f93dd384bc13fd33fc2df04f08bd 100644
--- a/runtime/vm/report_test.cc
+++ b/runtime/vm/report_test.cc
@@ -30,7 +30,8 @@ TEST_CASE(TraceJSWarning) {
// Skip time.
EXPECT_SUBSTRING("\"message\":{\"type\":\"JSCompatibilityWarning\","
"\"script\":{\"type\":\"@Script\",\"id\":"
- "\"scripts\\/Plug\",\"name\":\"Plug\",\"user_name\":"
+ "\"libraries\\/-1\\/scripts\\/Plug\","
+ "\"name\":\"Plug\",\"user_name\":"
"\"Plug\",\"kind\":\"script\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@String\"",
js.ToCString());
@@ -46,7 +47,8 @@ TEST_CASE(TraceJSWarning) {
}
EXPECT_EQ(2, trace_buffer->Length());
EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
- "\"@Script\",\"id\":\"scripts\\/Plug\",\"name\":\"Plug\","
+ "\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
+ "\"name\":\"Plug\","
"\"user_name\":\"Plug\",\"kind\":\"script\"},\"tokenPos\":0,"
"\"message\":{\"type\":\"@String\"",
trace_buffer->At(0)->message);
@@ -55,7 +57,8 @@ TEST_CASE(TraceJSWarning) {
trace_buffer->At(0)->message);
EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
- "\"@Script\",\"id\":\"scripts\\/Plug\",\"name\":\"Plug\","
+ "\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
+ "\"name\":\"Plug\","
"\"user_name\":\"Plug\",\"kind\":\"script\"},\"tokenPos\":1,"
"\"message\":{\"type\":\"@String\"",
trace_buffer->At(1)->message);
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698