Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: runtime/vm/coverage.cc

Issue 392933003: vm/observatory: Clean up script access (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/coverage.h ('k') | runtime/vm/coverage_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/coverage.cc
diff --git a/runtime/vm/coverage.cc b/runtime/vm/coverage.cc
index 37d38ba5d76936fcd6de8bed6bbfd2062a73f7f6..7109ffbeed4863019de203d2a1f9dc7c41651848 100644
--- a/runtime/vm/coverage.cc
+++ b/runtime/vm/coverage.cc
@@ -21,7 +21,7 @@ DEFINE_FLAG(charp, coverage_dir, NULL,
class CoverageFilterAll : public CoverageFilter {
public:
bool ShouldOutputCoverageFor(const Library& lib,
- const String& script_url,
+ const Script& script,
const Class& cls,
const Function& func) const {
return true;
@@ -155,7 +155,7 @@ void CodeCoverage::PrintClass(const Library& lib,
function ^= functions.At(i);
script = function.script();
saved_url = script.url();
- if (!filter->ShouldOutputCoverageFor(lib, saved_url, cls, function)) {
+ if (!filter->ShouldOutputCoverageFor(lib, script, cls, function)) {
i++;
continue;
}
@@ -175,7 +175,7 @@ void CodeCoverage::PrintClass(const Library& lib,
pos_to_line.Clear();
break;
}
- if (!filter->ShouldOutputCoverageFor(lib, saved_url, cls, function)) {
+ if (!filter->ShouldOutputCoverageFor(lib, script, cls, function)) {
i++;
continue;
}
@@ -200,7 +200,7 @@ void CodeCoverage::PrintClass(const Library& lib,
function ^= closures.At(i);
script = function.script();
saved_url = script.url();
- if (!filter->ShouldOutputCoverageFor(lib, saved_url, cls, function)) {
+ if (!filter->ShouldOutputCoverageFor(lib, script, cls, function)) {
i++;
continue;
}
« no previous file with comments | « runtime/vm/coverage.h ('k') | runtime/vm/coverage_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698