Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 392933003: vm/observatory: Clean up script access (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/script_view.html ('k') | runtime/vm/coverage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/service/object.dart
diff --git a/runtime/bin/vmservice/client/lib/src/service/object.dart b/runtime/bin/vmservice/client/lib/src/service/object.dart
index 044927d990c4bba7c702f6d49ce925c1d51c46a7..e9d4adb291d3635bc9c57878fb2a4c28698eec7b 100644
--- a/runtime/bin/vmservice/client/lib/src/service/object.dart
+++ b/runtime/bin/vmservice/client/lib/src/service/object.dart
@@ -1338,6 +1338,7 @@ class Script extends ServiceObject with Coverage {
@observable String kind;
@observable int firstTokenPos;
@observable int lastTokenPos;
+ @observable Library owningLibrary;
bool get canCache => true;
bool get immutable => true;
@@ -1360,13 +1361,18 @@ class Script extends ServiceObject with Coverage {
Map _tokenToCol = {};
void _update(ObservableMap map, bool mapIsRef) {
+ _upgradeCollection(map, isolate);
kind = map['kind'];
_url = map['name'];
_shortUrl = _url.substring(_url.lastIndexOf('/') + 1);
name = _shortUrl;
vmName = _url;
+ if (mapIsRef) {
+ return;
+ }
_processSource(map['source']);
_parseTokenPosTable(map['tokenPosTable']);
+ owningLibrary = map['owning_library'];
}
void _parseTokenPosTable(List<List<int>> table) {
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/script_view.html ('k') | runtime/vm/coverage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698