vm/observatory: Clean up script access

runtime/vm/report_test.cc

Index: runtime/vm/report_test.cc
diff --git a/runtime/vm/report_test.cc b/runtime/vm/report_test.cc
index ba66a9a565fcfbad55b43d3bc57febdf36bc6c8b..88b6839ce866f93dd384bc13fd33fc2df04f08bd 100644
--- a/runtime/vm/report_test.cc
+++ b/runtime/vm/report_test.cc
@@ -30,7 +30,8 @@ TEST_CASE(TraceJSWarning) {
       // Skip time.
       EXPECT_SUBSTRING("\"message\":{\"type\":\"JSCompatibilityWarning\","
                        "\"script\":{\"type\":\"@Script\",\"id\":"
-                       "\"scripts\\/Plug\",\"name\":\"Plug\",\"user_name\":"
+                       "\"libraries\\/-1\\/scripts\\/Plug\","

[Cutch, 2014/07/15 22:06:55]

Why is this -1?

[Michael Lippautz (Google), 2014/07/15 22:40:42]

script.Tokenize() does not process the script into the vm infrastructure, i.e.,
it does not assign it a library etc.

In this case we use -1 as library id in the JSON representation.

+                       "\"name\":\"Plug\",\"user_name\":"
                        "\"Plug\",\"kind\":\"script\"},\"tokenPos\":0,"
                        "\"message\":{\"type\":\"@String\"",
                        js.ToCString());
@@ -46,7 +47,8 @@ TEST_CASE(TraceJSWarning) {
   }
   EXPECT_EQ(2, trace_buffer->Length());
   EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
-                   "\"@Script\",\"id\":\"scripts\\/Plug\",\"name\":\"Plug\","
+                   "\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
+                   "\"name\":\"Plug\","
                    "\"user_name\":\"Plug\",\"kind\":\"script\"},\"tokenPos\":0,"
                    "\"message\":{\"type\":\"@String\"",
                    trace_buffer->At(0)->message);
@@ -55,7 +57,8 @@ TEST_CASE(TraceJSWarning) {
                    trace_buffer->At(0)->message);
 
   EXPECT_SUBSTRING("{\"type\":\"JSCompatibilityWarning\",\"script\":{\"type\":"
-                   "\"@Script\",\"id\":\"scripts\\/Plug\",\"name\":\"Plug\","
+                   "\"@Script\",\"id\":\"libraries\\/-1\\/scripts\\/Plug\","
+                   "\"name\":\"Plug\","
                    "\"user_name\":\"Plug\",\"kind\":\"script\"},\"tokenPos\":1,"
                    "\"message\":{\"type\":\"@String\"",
                    trace_buffer->At(1)->message);