vm/observatory: Clean up script access

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include <limits>
 #include "include/dart_api.h"
 #include "platform/assert.h"
@@ skipping 2496 matching lines @@
     return static_cast<RawScript::Kind>(raw_ptr()->kind_);
   }
   const char* GetKindAsCString() const;
   intptr_t line_offset() const { return raw_ptr()->line_offset_; }
   intptr_t col_offset() const { return raw_ptr()->col_offset_; }
 
   RawTokenStream* tokens() const { return raw_ptr()->tokens_; }
 
   void Tokenize(const String& private_key) const;
 
+  RawLibrary* FindLibrary() const;
   RawString* GetLine(intptr_t line_number) const;
   RawString* GetSnippet(intptr_t from_token_pos,
                         intptr_t to_token_pos) const;
   RawString* GetSnippet(intptr_t from_line,
                         intptr_t from_column,
                         intptr_t to_line,
                         intptr_t to_column) const;
 
   void SetLocationOffset(intptr_t line_offset, intptr_t col_offset) const;
 
@@ skipping 142 matching lines @@
   RawObject* LookupImportedObject(const String& name) const;
   RawClass* LookupClass(const String& name) const;
   RawClass* LookupClassAllowPrivate(const String& name) const;
   RawClass* LookupLocalClass(const String& name) const;
   RawField* LookupFieldAllowPrivate(const String& name) const;
   RawField* LookupLocalField(const String& name) const;
   RawFunction* LookupFunctionAllowPrivate(const String& name) const;
   RawFunction* LookupLocalFunction(const String& name) const;
   RawLibraryPrefix* LookupLocalLibraryPrefix(const String& name) const;
   RawScript* LookupScript(const String& url) const;
-  RawArray* LoadedScripts() const;
+  RawArray* LoadedScripts(bool cached = true) const;

[Michael Lippautz (Google), 2014/07/15 17:52:55]

Make parameter explicit?

LoadedScripts() uses a cache which is not ideal in the case of lazy loading.

 
   // Resolve name in the scope of this library. First check the cache
   // of already resolved names for this library. Then look in the
   // local dictionary for the unmangled name N, the getter name get:N
   // and setter name set:N.
   // If the local dictionary contains no entry for these names,
   // look in the scopes of all libraries that are imported
   // without a library prefix.
   RawObject* ResolveName(const String& name) const;
 
@@ skipping 4487 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_