Fix data race with synthetic delay initialization

base/debug/trace_event_synthetic_delay_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/trace_event_synthetic_delay.h"
 
+#include "base/threading/simple_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace debug {
 namespace {
 
 const int kTargetDurationMs = 100;
 // Allow some leeway in timings to make it possible to run these tests with a
 // wall clock time source too.
 const int kShortDurationMs = 10;
+const char kThreadedDelayName[] = "test.ThreadedDelay";
 
 }  // namespace
 
 class TraceEventSyntheticDelayTest : public testing::Test,
                                      public TraceEventSyntheticDelayClock {
  public:
   TraceEventSyntheticDelayTest() {}
   virtual ~TraceEventSyntheticDelayTest() {
     ResetTraceEventSyntheticDelays();
   }
@@ skipping 118 matching lines @@
   EXPECT_FALSE(end_times[1].is_null());
 
   delay->EndParallel(end_times[0]);
   EXPECT_GE((Now() - start_time).InMilliseconds(), kTargetDurationMs);
 
   start_time = Now();
   delay->EndParallel(end_times[1]);
   EXPECT_LT((Now() - start_time).InMilliseconds(), kShortDurationMs);
 }
 
+class ThreadWithSyntheticDelay : public SimpleThread {
+ public:
+  ThreadWithSyntheticDelay()
+      : SimpleThread("delay_test", SimpleThread::Options()) {}
+
+  virtual void Run() OVERRIDE {
+    TRACE_EVENT_SYNTHETIC_DELAY(kThreadedDelayName);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ThreadWithSyntheticDelay);
+};
+
+TEST_F(TraceEventSyntheticDelayTest, ThreadedSetup) {
+  // This test is designed to exercise various multithreaded scenarios with
+  // synthetic delays so that dynamic analyzers like TSAN can spot any

[Alexander Potapenko, 2014/07/15 14:30:15]

That's 'TSan', not 'TSAN' :)

Have you actually tried running it on this test?

+  // problems.
+  ThreadWithSyntheticDelay threads[2];
+
+  for (size_t i = 0; i < arraysize(threads); ++i)
+      threads[i].Start();

[Alexander Potapenko, 2014/07/15 14:30:15]

I think there should be two-space indentation here (and in the loop below)

+  TraceEventSyntheticDelay* delay =
+      TraceEventSyntheticDelay::Lookup(kThreadedDelayName);
+  delay->SetTargetDuration(
+      base::TimeDelta::FromMilliseconds(kShortDurationMs));
+  for (size_t i = 0; i < arraysize(threads); ++i)
+      threads[i].Join();
+}
+
 }  // namespace debug
 }  // namespace base