Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 392913002: Simplify an error condition in requestFullScreenForElement() (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Simplify an error condition in requestFullScreenForElement() Use the existing getter for the top element and do the ancestor test in a more direct manner. BUG=383813 R=falken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/dom/FullscreenElementStack.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
PTAL. Depends on https://codereview.chromium.org/390363002/
6 years, 5 months ago (2014-07-15 13:17:26 UTC) #1
falken
neat, lgtm
6 years, 5 months ago (2014-07-17 02:30:24 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-17 08:46:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/392913002/1
6 years, 5 months ago (2014-07-17 08:47:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-17 10:16:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 11:25:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17449)
6 years, 5 months ago (2014-07-17 11:25:25 UTC) #7
philipj_slow
6 years, 5 months ago (2014-07-17 11:46:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r178360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698