sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart - Issue 392873002: Element-model refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

Issue 392873002: Element-model refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compiler.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart » ('j') | sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

index c10471689bf60eec174ca0650e8a83191e639cce..9ed654cf5e4ceac76ec7981626918409dee59d9f 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

@@ -205,7 +205,7 @@ class DartBackend extends Backend {

Link<Element> optionalParameters =

element.functionSignature.optionalParameters;

for (final optional in optionalParameters) {

- if (optional.kind != ElementKind.FIELD_PARAMETER) continue;

+ if (!optional.isInitializingFormal) continue;

fixedMemberNames.add(optional.name);

}

@@ -301,7 +301,7 @@ class DartBackend extends Backend {

}

ElementAst elementAst = parse(element);

- if (element.isMember) {

+ if (element.isClassMember) {

ClassElement enclosingClass = element.enclosingClass;

assert(enclosingClass.isClass);

assert(enclosingClass.isTopLevel);