sdk/lib/_internal/compiler/implementation/compile_time_constants.dart - Issue 392873002: Element-model refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

Issue 392873002: Element-model refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/closure.dart ('k') | sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | sdk/lib/_internal/compiler/implementation/elements/elements.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

diff --git a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

index 8a21068dc5082109085d987f069c4878c05211d3..52e988ea9af1be5d4fd32e647b7eb79ec7344404 100644

--- a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

+++ b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

@@ -816,9 +816,9 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {

Node node = parameter.node;

potentiallyCheckType(node, parameter, argument);

definitions[parameter] = argument;

- if (parameter.kind == ElementKind.FIELD_PARAMETER) {

- FieldParameterElement fieldParameterElement = parameter;

- updateFieldValue(node, fieldParameterElement.fieldElement, argument);

+ if (parameter.isInitializingFormal) {

+ InitializingFormalElement initializingFormal = parameter;

+ updateFieldValue(node, initializingFormal.fieldElement, argument);

}

});

}