Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 39285: Support loading extensions into the bookmark toolbar. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by Matt Perry
Modified:
6 years ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Support loading extensions into the bookmark toolbar. Misc cleanup: - remove duplicate comments on Extension accessors - remove useless function in ExtensionsService Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11294

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 7

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -59 lines) Patch
M chrome/browser/extensions/extension.h View 1 2 3 5 chunks +21 lines, -34 lines 0 comments Download
M chrome/browser/extensions/extension.cc View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_view.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_view.cc View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 2 3 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 2 3 10 chunks +87 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/good/extension1/1/index.html View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/good/extension1/1/manifest.json View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/good/extension1/1/toolstrip.html View 1 chunk +16 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 6 (0 generated)
Matt Perry
sky: please review bookmark_bar_view.* erikkay: everything else
8 years, 2 months ago (2009-03-06 23:06:13 UTC) #1
sky
You need to update BookmarkBarView::SetProfile to remove the extensions as well. Have you tried drag ...
8 years, 2 months ago (2009-03-07 00:04:54 UTC) #2
Erik does not do reviews
http://codereview.chromium.org/39285/diff/1012/1019 File chrome/browser/extensions/extensions_service.cc (left): http://codereview.chromium.org/39285/diff/1012/1019#oldcode108 Line 108: GURL url = Extension::GetResourceURL(extension->url(), "index.html"); I don't understand ...
8 years, 2 months ago (2009-03-07 00:24:39 UTC) #3
Erik does not do reviews
LGTM
8 years, 2 months ago (2009-03-07 00:30:40 UTC) #4
Matt Perry
re: SetProfile: done re: extensions switch: There is one, and if it isn't set, none ...
8 years, 2 months ago (2009-03-07 00:42:20 UTC) #5
sky
8 years, 2 months ago (2009-03-07 01:15:57 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06