Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392823002: remove PLT.BeginToFinish{,Doc}_AfterPreconnectRequest (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

remove PLT.BeginToFinish{,Doc}_AfterPreconnectRequest The experiment is no longer active, marking the PLT histograms as obsolete. BUG=386888 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284013

Patch Set 1 #

Patch Set 2 : mark as obsolete #

Patch Set 3 : set kouhei@ as the histogram owner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/renderer/page_load_histograms.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 5 months ago (2014-07-15 03:38:23 UTC) #1
Ilya Sherman
Please mark the histograms as <obsolete> rather than deleting them.
6 years, 5 months ago (2014-07-15 03:47:37 UTC) #2
kouhei (in TOK)
On 2014/07/15 03:47:37, Ilya Sherman wrote: > Please mark the histograms as <obsolete> rather than ...
6 years, 5 months ago (2014-07-15 03:53:29 UTC) #3
Ilya Sherman
LGTM, thanks.
6 years, 5 months ago (2014-07-15 03:57:02 UTC) #4
kouhei (in TOK)
On 2014/07/15 03:57:02, Ilya Sherman wrote: > LGTM, thanks. Thanks! tonyg: Would you review changes ...
6 years, 5 months ago (2014-07-15 03:58:36 UTC) #5
kouhei (in TOK)
> tonyg: Would you review changes in chrome/? Friendly ping
6 years, 5 months ago (2014-07-17 00:57:08 UTC) #6
Alexei Svitkine (slow)
lgtm
6 years, 5 months ago (2014-07-17 13:35:19 UTC) #7
tonyg
lgtm
6 years, 5 months ago (2014-07-17 16:23:54 UTC) #8
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-18 00:43:04 UTC) #9
kouhei (in TOK)
Thanks for review!
6 years, 5 months ago (2014-07-18 00:43:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/392823002/40001
6 years, 5 months ago (2014-07-18 00:45:16 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 05:42:39 UTC) #12
Message was sent while issue was closed. 
Change committed as 284013

Powered by Google App Engine
This is Rietveld 408576698