Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392803003: a11y/history: don't change focus when a user clicks on bookmark star icon. (Closed)

Created:
6 years, 5 months ago by Dan Beam
Modified:
6 years, 5 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

a11y/history: don't change focus when a user clicks on bookmark star icon. R=dmazzoni@chromium.org BUG=392813 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284782

Patch Set 1 : nit #

Patch Set 2 : add star to tab order #

Patch Set 3 : add title #

Total comments: 2

Patch Set 4 : nit #

Patch Set 5 : better desc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -36 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/history/history.js View 1 2 3 8 chunks +74 lines, -36 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dan Beam
6 years, 5 months ago (2014-07-15 02:55:48 UTC) #1
dmazzoni
See comments on bug - I wonder if the star should always be available, just ...
6 years, 5 months ago (2014-07-15 07:13:15 UTC) #2
Dan Beam
updated
6 years, 5 months ago (2014-07-22 16:00:18 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/392803003/diff/60001/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://codereview.chromium.org/392803003/diff/60001/chrome/browser/resources/history/history.js#newcode499 chrome/browser/resources/history/history.js:499: var toFocus = e.keyCode == 37 ? controls[i ...
6 years, 5 months ago (2014-07-22 16:59:16 UTC) #4
Dan Beam
https://codereview.chromium.org/392803003/diff/60001/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://codereview.chromium.org/392803003/diff/60001/chrome/browser/resources/history/history.js#newcode499 chrome/browser/resources/history/history.js:499: var toFocus = e.keyCode == 37 ? controls[i - ...
6 years, 5 months ago (2014-07-22 18:10:06 UTC) #5
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-22 18:11:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/392803003/100001
6 years, 5 months ago (2014-07-22 18:12:36 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 21:37:50 UTC) #8
Message was sent while issue was closed. 
Change committed as 284782

Powered by Google App Engine
This is Rietveld 408576698