Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: mojo/public/cpp/system/core.h

Issue 392783006: Mojo: Split public/cpp/system/core.h into pieces (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/system/buffer.h ('k') | mojo/public/cpp/system/data_pipe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/system/core.h
diff --git a/mojo/public/cpp/system/core.h b/mojo/public/cpp/system/core.h
index d73bb296514ea937a7896f3fe293e50983734419..b08a5a6abe1d7fec11581ae12f80a8cfe1779094 100644
--- a/mojo/public/cpp/system/core.h
+++ b/mojo/public/cpp/system/core.h
@@ -1,555 +1,15 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef MOJO_PUBLIC_CPP_SYSTEM_CORE_H_
#define MOJO_PUBLIC_CPP_SYSTEM_CORE_H_
-#include <assert.h>
-#include <stddef.h>
-
-#include <limits>
-
-#include "mojo/public/c/system/core.h"
-#include "mojo/public/c/system/system_export.h"
+#include "mojo/public/cpp/system/buffer.h"
+#include "mojo/public/cpp/system/data_pipe.h"
+#include "mojo/public/cpp/system/functions.h"
+#include "mojo/public/cpp/system/handle.h"
#include "mojo/public/cpp/system/macros.h"
-
-namespace mojo {
-
-// OVERVIEW
-//
-// |Handle| and |...Handle|:
-//
-// |Handle| is a simple, copyable wrapper for the C type |MojoHandle| (which is
-// just an integer). Its purpose is to increase type-safety, not provide
-// lifetime management. For the same purpose, we have trivial *subclasses* of
-// |Handle|, e.g., |MessagePipeHandle| and |DataPipeProducerHandle|. |Handle|
-// and its subclasses impose *no* extra overhead over using |MojoHandle|s
-// directly.
-//
-// Note that though we provide constructors for |Handle|/|...Handle| from a
-// |MojoHandle|, we do not provide, e.g., a constructor for |MessagePipeHandle|
-// from a |Handle|. This is for type safety: If we did, you'd then be able to
-// construct a |MessagePipeHandle| from, e.g., a |DataPipeProducerHandle| (since
-// it's a |Handle|).
-//
-// |ScopedHandleBase| and |Scoped...Handle|:
-//
-// |ScopedHandleBase<HandleType>| is a templated scoped wrapper, for the handle
-// types above (in the same sense that a C++11 |unique_ptr<T>| is a scoped
-// wrapper for a |T*|). It provides lifetime management, closing its owned
-// handle on destruction. It also provides (emulated) move semantics, again
-// along the lines of C++11's |unique_ptr| (and exactly like Chromium's
-// |scoped_ptr|).
-//
-// |ScopedHandle| is just (a typedef of) a |ScopedHandleBase<Handle>|.
-// Similarly, |ScopedMessagePipeHandle| is just a
-// |ScopedHandleBase<MessagePipeHandle>|. Etc. Note that a
-// |ScopedMessagePipeHandle| is *not* a (subclass of) |ScopedHandle|.
-//
-// Wrapper functions:
-//
-// We provide simple wrappers for the |Mojo...()| functions (in
-// mojo/public/c/system/core.h -- see that file for details on individual
-// functions).
-//
-// The general guideline is functions that imply ownership transfer of a handle
-// should take (or produce) an appropriate |Scoped...Handle|, while those that
-// don't take a |...Handle|. For example, |CreateMessagePipe()| has two
-// |ScopedMessagePipe| "out" parameters, whereas |Wait()| and |WaitMany()| take
-// |Handle| parameters. Some, have both: e.g., |DuplicatedBuffer()| takes a
-// suitable (unscoped) handle (e.g., |SharedBufferHandle|) "in" parameter and
-// produces a suitable scoped handle (e.g., |ScopedSharedBufferHandle| a.k.a.
-// |ScopedHandleBase<SharedBufferHandle>|) as an "out" parameter.
-//
-// An exception are some of the |...Raw()| functions. E.g., |CloseRaw()| takes a
-// |Handle|, leaving the user to discard the handle.
-//
-// More significantly, |WriteMessageRaw()| exposes the full API complexity of
-// |MojoWriteMessage()| (but doesn't require any extra overhead). It takes a raw
-// array of |Handle|s as input, and takes ownership of them (i.e., invalidates
-// them) on *success* (but not on failure). There are a number of reasons for
-// this. First, C++03 |std::vector|s cannot contain the move-only
-// |Scoped...Handle|s. Second, |std::vector|s impose extra overhead
-// (necessitating heap-allocation of the buffer). Third, |std::vector|s wouldn't
-// provide the desired level of flexibility/safety: a vector of handles would
-// have to be all of the same type (probably |Handle|/|ScopedHandle|). Fourth,
-// it's expected to not be used directly, but instead be used by generated
-// bindings.
-//
-// Other |...Raw()| functions expose similar rough edges, e.g., dealing with raw
-// pointers (and lengths) instead of taking |std::vector|s or similar.
-
-// Standalone functions --------------------------------------------------------
-
-inline MojoTimeTicks GetTimeTicksNow() {
- return MojoGetTimeTicksNow();
-}
-
-// ScopedHandleBase ------------------------------------------------------------
-
-// Scoper for the actual handle types defined further below. It's move-only,
-// like the C++11 |unique_ptr|.
-template <class HandleType>
-class ScopedHandleBase {
- MOJO_MOVE_ONLY_TYPE_FOR_CPP_03(ScopedHandleBase, RValue)
-
- public:
- ScopedHandleBase() {}
- explicit ScopedHandleBase(HandleType handle) : handle_(handle) {}
- ~ScopedHandleBase() { CloseIfNecessary(); }
-
- template <class CompatibleHandleType>
- explicit ScopedHandleBase(ScopedHandleBase<CompatibleHandleType> other)
- : handle_(other.release()) {
- }
-
- // Move-only constructor and operator=.
- ScopedHandleBase(RValue other) : handle_(other.object->release()) {}
- ScopedHandleBase& operator=(RValue other) {
- if (other.object != this) {
- CloseIfNecessary();
- handle_ = other.object->release();
- }
- return *this;
- }
-
- const HandleType& get() const { return handle_; }
-
- template <typename PassedHandleType>
- static ScopedHandleBase<HandleType> From(
- ScopedHandleBase<PassedHandleType> other) {
- MOJO_COMPILE_ASSERT(
- sizeof(static_cast<PassedHandleType*>(static_cast<HandleType*>(0))),
- HandleType_is_not_a_subtype_of_PassedHandleType);
- return ScopedHandleBase<HandleType>(
- static_cast<HandleType>(other.release().value()));
- }
-
- void swap(ScopedHandleBase& other) {
- handle_.swap(other.handle_);
- }
-
- HandleType release() MOJO_WARN_UNUSED_RESULT {
- HandleType rv;
- rv.swap(handle_);
- return rv;
- }
-
- void reset(HandleType handle = HandleType()) {
- CloseIfNecessary();
- handle_ = handle;
- }
-
- bool is_valid() const {
- return handle_.is_valid();
- }
-
- private:
- void CloseIfNecessary() {
- if (!handle_.is_valid())
- return;
- MojoResult result MOJO_ALLOW_UNUSED = MojoClose(handle_.value());
- assert(result == MOJO_RESULT_OK);
- }
-
- HandleType handle_;
-};
-
-template <typename HandleType>
-inline ScopedHandleBase<HandleType> MakeScopedHandle(HandleType handle) {
- return ScopedHandleBase<HandleType>(handle);
-}
-
-// Handle ----------------------------------------------------------------------
-
-const MojoHandle kInvalidHandleValue = MOJO_HANDLE_INVALID;
-
-// Wrapper base class for |MojoHandle|.
-class Handle {
- public:
- Handle() : value_(kInvalidHandleValue) {}
- explicit Handle(MojoHandle value) : value_(value) {}
- ~Handle() {}
-
- void swap(Handle& other) {
- MojoHandle temp = value_;
- value_ = other.value_;
- other.value_ = temp;
- }
-
- bool is_valid() const {
- return value_ != kInvalidHandleValue;
- }
-
- MojoHandle value() const { return value_; }
- MojoHandle* mutable_value() { return &value_; }
- void set_value(MojoHandle value) { value_ = value; }
-
- private:
- MojoHandle value_;
-
- // Copying and assignment allowed.
-};
-
-// Should have zero overhead.
-MOJO_COMPILE_ASSERT(sizeof(Handle) == sizeof(MojoHandle),
- bad_size_for_cpp_Handle);
-
-// The scoper should also impose no more overhead.
-typedef ScopedHandleBase<Handle> ScopedHandle;
-MOJO_COMPILE_ASSERT(sizeof(ScopedHandle) == sizeof(Handle),
- bad_size_for_cpp_ScopedHandle);
-
-inline MojoResult Wait(const Handle& handle,
- MojoHandleSignals signals,
- MojoDeadline deadline) {
- return MojoWait(handle.value(), signals, deadline);
-}
-
-// |HandleVectorType| and |FlagsVectorType| should be similar enough to
-// |std::vector<Handle>| and |std::vector<MojoHandleSignals>|, respectively:
-// - They should have a (const) |size()| method that returns an unsigned type.
-// - They must provide contiguous storage, with access via (const) reference to
-// that storage provided by a (const) |operator[]()| (by reference).
-template <class HandleVectorType, class FlagsVectorType>
-inline MojoResult WaitMany(const HandleVectorType& handles,
- const FlagsVectorType& signals,
- MojoDeadline deadline) {
- if (signals.size() != handles.size())
- return MOJO_RESULT_INVALID_ARGUMENT;
- if (handles.size() > std::numeric_limits<uint32_t>::max())
- return MOJO_RESULT_OUT_OF_RANGE;
-
- if (handles.size() == 0)
- return MojoWaitMany(NULL, NULL, 0, deadline);
-
- const Handle& first_handle = handles[0];
- const MojoHandleSignals& first_signals = signals[0];
- return MojoWaitMany(
- reinterpret_cast<const MojoHandle*>(&first_handle),
- reinterpret_cast<const MojoHandleSignals*>(&first_signals),
- static_cast<uint32_t>(handles.size()),
- deadline);
-}
-
-// |Close()| takes ownership of the handle, since it'll invalidate it.
-// Note: There's nothing to do, since the argument will be destroyed when it
-// goes out of scope.
-template <class HandleType>
-inline void Close(ScopedHandleBase<HandleType> /*handle*/) {}
-
-// Most users should typically use |Close()| (above) instead.
-inline MojoResult CloseRaw(Handle handle) {
- return MojoClose(handle.value());
-}
-
-// Strict weak ordering, so that |Handle|s can be used as keys in |std::map|s,
-// etc.
-inline bool operator<(const Handle& a, const Handle& b) {
- return a.value() < b.value();
-}
-
-// MessagePipeHandle -----------------------------------------------------------
-
-class MessagePipeHandle : public Handle {
- public:
- MessagePipeHandle() {}
- explicit MessagePipeHandle(MojoHandle value) : Handle(value) {}
-
- // Copying and assignment allowed.
-};
-
-MOJO_COMPILE_ASSERT(sizeof(MessagePipeHandle) == sizeof(Handle),
- bad_size_for_cpp_MessagePipeHandle);
-
-typedef ScopedHandleBase<MessagePipeHandle> ScopedMessagePipeHandle;
-MOJO_COMPILE_ASSERT(sizeof(ScopedMessagePipeHandle) ==
- sizeof(MessagePipeHandle),
- bad_size_for_cpp_ScopedMessagePipeHandle);
-
-inline MojoResult CreateMessagePipe(const MojoCreateMessagePipeOptions* options,
- ScopedMessagePipeHandle* message_pipe0,
- ScopedMessagePipeHandle* message_pipe1) {
- assert(message_pipe0);
- assert(message_pipe1);
- MessagePipeHandle handle0;
- MessagePipeHandle handle1;
- MojoResult rv = MojoCreateMessagePipe(options,
- handle0.mutable_value(),
- handle1.mutable_value());
- // Reset even on failure (reduces the chances that a "stale"/incorrect handle
- // will be used).
- message_pipe0->reset(handle0);
- message_pipe1->reset(handle1);
- return rv;
-}
-
-// These "raw" versions fully expose the underlying API, but don't help with
-// ownership of handles (especially when writing messages).
-// TODO(vtl): Write "baked" versions.
-inline MojoResult WriteMessageRaw(MessagePipeHandle message_pipe,
- const void* bytes,
- uint32_t num_bytes,
- const MojoHandle* handles,
- uint32_t num_handles,
- MojoWriteMessageFlags flags) {
- return MojoWriteMessage(message_pipe.value(), bytes, num_bytes, handles,
- num_handles, flags);
-}
-
-inline MojoResult ReadMessageRaw(MessagePipeHandle message_pipe,
- void* bytes,
- uint32_t* num_bytes,
- MojoHandle* handles,
- uint32_t* num_handles,
- MojoReadMessageFlags flags) {
- return MojoReadMessage(message_pipe.value(), bytes, num_bytes, handles,
- num_handles, flags);
-}
-
-// A wrapper class that automatically creates a message pipe and owns both
-// handles.
-class MessagePipe {
- public:
- MessagePipe();
- explicit MessagePipe(const MojoCreateMessagePipeOptions& options);
- ~MessagePipe();
-
- ScopedMessagePipeHandle handle0;
- ScopedMessagePipeHandle handle1;
-};
-
-inline MessagePipe::MessagePipe() {
- MojoResult result MOJO_ALLOW_UNUSED =
- CreateMessagePipe(NULL, &handle0, &handle1);
- assert(result == MOJO_RESULT_OK);
-}
-
-inline MessagePipe::MessagePipe(const MojoCreateMessagePipeOptions& options) {
- MojoResult result MOJO_ALLOW_UNUSED =
- CreateMessagePipe(&options, &handle0, &handle1);
- assert(result == MOJO_RESULT_OK);
-}
-
-inline MessagePipe::~MessagePipe() {
-}
-
-// DataPipeProducerHandle and DataPipeConsumerHandle ---------------------------
-
-class DataPipeProducerHandle : public Handle {
- public:
- DataPipeProducerHandle() {}
- explicit DataPipeProducerHandle(MojoHandle value) : Handle(value) {}
-
- // Copying and assignment allowed.
-};
-
-MOJO_COMPILE_ASSERT(sizeof(DataPipeProducerHandle) == sizeof(Handle),
- bad_size_for_cpp_DataPipeProducerHandle);
-
-typedef ScopedHandleBase<DataPipeProducerHandle> ScopedDataPipeProducerHandle;
-MOJO_COMPILE_ASSERT(sizeof(ScopedDataPipeProducerHandle) ==
- sizeof(DataPipeProducerHandle),
- bad_size_for_cpp_ScopedDataPipeProducerHandle);
-
-class DataPipeConsumerHandle : public Handle {
- public:
- DataPipeConsumerHandle() {}
- explicit DataPipeConsumerHandle(MojoHandle value) : Handle(value) {}
-
- // Copying and assignment allowed.
-};
-
-MOJO_COMPILE_ASSERT(sizeof(DataPipeConsumerHandle) == sizeof(Handle),
- bad_size_for_cpp_DataPipeConsumerHandle);
-
-typedef ScopedHandleBase<DataPipeConsumerHandle> ScopedDataPipeConsumerHandle;
-MOJO_COMPILE_ASSERT(sizeof(ScopedDataPipeConsumerHandle) ==
- sizeof(DataPipeConsumerHandle),
- bad_size_for_cpp_ScopedDataPipeConsumerHandle);
-
-inline MojoResult CreateDataPipe(
- const MojoCreateDataPipeOptions* options,
- ScopedDataPipeProducerHandle* data_pipe_producer,
- ScopedDataPipeConsumerHandle* data_pipe_consumer) {
- assert(data_pipe_producer);
- assert(data_pipe_consumer);
- DataPipeProducerHandle producer_handle;
- DataPipeConsumerHandle consumer_handle;
- MojoResult rv = MojoCreateDataPipe(options, producer_handle.mutable_value(),
- consumer_handle.mutable_value());
- // Reset even on failure (reduces the chances that a "stale"/incorrect handle
- // will be used).
- data_pipe_producer->reset(producer_handle);
- data_pipe_consumer->reset(consumer_handle);
- return rv;
-}
-
-inline MojoResult WriteDataRaw(DataPipeProducerHandle data_pipe_producer,
- const void* elements,
- uint32_t* num_bytes,
- MojoWriteDataFlags flags) {
- return MojoWriteData(data_pipe_producer.value(), elements, num_bytes, flags);
-}
-
-inline MojoResult BeginWriteDataRaw(DataPipeProducerHandle data_pipe_producer,
- void** buffer,
- uint32_t* buffer_num_bytes,
- MojoWriteDataFlags flags) {
- return MojoBeginWriteData(data_pipe_producer.value(), buffer,
- buffer_num_bytes, flags);
-}
-
-inline MojoResult EndWriteDataRaw(DataPipeProducerHandle data_pipe_producer,
- uint32_t num_bytes_written) {
- return MojoEndWriteData(data_pipe_producer.value(), num_bytes_written);
-}
-
-inline MojoResult ReadDataRaw(DataPipeConsumerHandle data_pipe_consumer,
- void* elements,
- uint32_t* num_bytes,
- MojoReadDataFlags flags) {
- return MojoReadData(data_pipe_consumer.value(), elements, num_bytes, flags);
-}
-
-inline MojoResult BeginReadDataRaw(DataPipeConsumerHandle data_pipe_consumer,
- const void** buffer,
- uint32_t* buffer_num_bytes,
- MojoReadDataFlags flags) {
- return MojoBeginReadData(data_pipe_consumer.value(), buffer, buffer_num_bytes,
- flags);
-}
-
-inline MojoResult EndReadDataRaw(DataPipeConsumerHandle data_pipe_consumer,
- uint32_t num_bytes_read) {
- return MojoEndReadData(data_pipe_consumer.value(), num_bytes_read);
-}
-
-// A wrapper class that automatically creates a data pipe and owns both handles.
-// TODO(vtl): Make an even more friendly version? (Maybe templatized for a
-// particular type instead of some "element"? Maybe functions that take
-// vectors?)
-class DataPipe {
- public:
- DataPipe();
- explicit DataPipe(const MojoCreateDataPipeOptions& options);
- ~DataPipe();
-
- ScopedDataPipeProducerHandle producer_handle;
- ScopedDataPipeConsumerHandle consumer_handle;
-};
-
-inline DataPipe::DataPipe() {
- MojoResult result MOJO_ALLOW_UNUSED =
- CreateDataPipe(NULL, &producer_handle, &consumer_handle);
- assert(result == MOJO_RESULT_OK);
-}
-
-inline DataPipe::DataPipe(const MojoCreateDataPipeOptions& options) {
- MojoResult result MOJO_ALLOW_UNUSED =
- CreateDataPipe(&options, &producer_handle, &consumer_handle);
- assert(result == MOJO_RESULT_OK);
-}
-
-inline DataPipe::~DataPipe() {
-}
-
-// SharedBufferHandle ----------------------------------------------------------
-
-class SharedBufferHandle : public Handle {
- public:
- SharedBufferHandle() {}
- explicit SharedBufferHandle(MojoHandle value) : Handle(value) {}
-
- // Copying and assignment allowed.
-};
-
-MOJO_COMPILE_ASSERT(sizeof(SharedBufferHandle) == sizeof(Handle),
- bad_size_for_cpp_SharedBufferHandle);
-
-typedef ScopedHandleBase<SharedBufferHandle> ScopedSharedBufferHandle;
-MOJO_COMPILE_ASSERT(sizeof(ScopedSharedBufferHandle) ==
- sizeof(SharedBufferHandle),
- bad_size_for_cpp_ScopedSharedBufferHandle);
-
-inline MojoResult CreateSharedBuffer(
- const MojoCreateSharedBufferOptions* options,
- uint64_t num_bytes,
- ScopedSharedBufferHandle* shared_buffer) {
- assert(shared_buffer);
- SharedBufferHandle handle;
- MojoResult rv = MojoCreateSharedBuffer(options, num_bytes,
- handle.mutable_value());
- // Reset even on failure (reduces the chances that a "stale"/incorrect handle
- // will be used).
- shared_buffer->reset(handle);
- return rv;
-}
-
-// TODO(vtl): This (and also the functions below) are templatized to allow for
-// future/other buffer types. A bit "safer" would be to overload this function
-// manually. (The template enforces that the in and out handles to be of the
-// same type.)
-template <class BufferHandleType>
-inline MojoResult DuplicateBuffer(
- BufferHandleType buffer,
- const MojoDuplicateBufferHandleOptions* options,
- ScopedHandleBase<BufferHandleType>* new_buffer) {
- assert(new_buffer);
- BufferHandleType handle;
- MojoResult rv = MojoDuplicateBufferHandle(
- buffer.value(), options, handle.mutable_value());
- // Reset even on failure (reduces the chances that a "stale"/incorrect handle
- // will be used).
- new_buffer->reset(handle);
- return rv;
-}
-
-template <class BufferHandleType>
-inline MojoResult MapBuffer(BufferHandleType buffer,
- uint64_t offset,
- uint64_t num_bytes,
- void** pointer,
- MojoMapBufferFlags flags) {
- assert(buffer.is_valid());
- return MojoMapBuffer(buffer.value(), offset, num_bytes, pointer, flags);
-}
-
-inline MojoResult UnmapBuffer(void* pointer) {
- assert(pointer);
- return MojoUnmapBuffer(pointer);
-}
-
-// A wrapper class that automatically creates a shared buffer and owns the
-// handle.
-class SharedBuffer {
- public:
- explicit SharedBuffer(uint64_t num_bytes);
- SharedBuffer(uint64_t num_bytes,
- const MojoCreateSharedBufferOptions& options);
- ~SharedBuffer();
-
- ScopedSharedBufferHandle handle;
-};
-
-inline SharedBuffer::SharedBuffer(uint64_t num_bytes) {
- MojoResult result MOJO_ALLOW_UNUSED =
- CreateSharedBuffer(NULL, num_bytes, &handle);
- assert(result == MOJO_RESULT_OK);
-}
-
-inline SharedBuffer::SharedBuffer(
- uint64_t num_bytes,
- const MojoCreateSharedBufferOptions& options) {
- MojoResult result MOJO_ALLOW_UNUSED =
- CreateSharedBuffer(&options, num_bytes, &handle);
- assert(result == MOJO_RESULT_OK);
-}
-
-inline SharedBuffer::~SharedBuffer() {
-}
-
-} // namespace mojo
+#include "mojo/public/cpp/system/message_pipe.h"
#endif // MOJO_PUBLIC_CPP_SYSTEM_CORE_H_
« no previous file with comments | « mojo/public/cpp/system/buffer.h ('k') | mojo/public/cpp/system/data_pipe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698