Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 392703002: ui/gfx: remove redundant 32x32 DashedRect drawing if a dest rect is empty (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: remove redundant 32x32 DashedRect drawing if a dest rect is empty Even if the dest rect is empty, it draws 32x32 DashedRect. It removes this redundant drawing. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/gfx/canvas.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hyunki
Please take a look. Thanks. :)
6 years, 5 months ago (2014-07-14 17:11:59 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-14 19:21:31 UTC) #2
brettw
Please just add the necessary reviewers rather than extra ones.
6 years, 5 months ago (2014-07-14 19:24:53 UTC) #3
hyunki
On 2014/07/14 19:24:53, brettw wrote: > Please just add the necessary reviewers rather than extra ...
6 years, 5 months ago (2014-07-14 22:45:16 UTC) #4
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-14 22:45:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/392703002/1
6 years, 5 months ago (2014-07-14 22:47:27 UTC) #6
hyunki
The CQ bit was unchecked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-14 22:47:56 UTC) #7
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-14 22:55:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/392703002/1
6 years, 5 months ago (2014-07-14 22:56:58 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 01:05:18 UTC) #10
Message was sent while issue was closed.
Change committed as 283121

Powered by Google App Engine
This is Rietveld 408576698