Issue 39268: Rebaseline form-element-geometry-expected....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39268: Rebaseline form-element-geometry-expected.... (Closed)

Created:
11 years, 9 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rebaseline form-element-geometry-expected. There are basically two sets of changes from the last baseline, which was done by Finnur on Jan. 26. One is a fix to SELECT scrollbars that looks like it's strictly more correct. The other is the removal of a [border bgcolor="#000000"] on the BRs inside some SELECTs, which I'm less certain of, but which isn't present upstream and wasn't present in our baseline before the last set of changes to it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11153

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -14 lines)			Patch
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/form-element-geometry-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/form-element-geometry-expected.png	View	Binary file		0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/form-element-geometry-expected.txt	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

Both of these changes look good. We didn't have a good justification as to why ...

11 years, 9 months ago (2009-03-06 18:27:20 UTC) #2

Peter Kasting

11 years, 9 months ago (2009-03-06 18:40:41 UTC) #3

I don't know how layout tests on other platforms work :(

I see that chromium-linux has a png (but no txt) for this test, and the image is
laid out very much like the new Windows image.  chromium-mac has nothing at all
for this test.  Maybe we've never generated a Mac baseline?  Not sure what I
should be doing here.

Expand Messages | Collapse Messages