Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 392653005: Fix memory leaks when calling EVP_PKEY_get1_RSA. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix memory leaks when calling EVP_PKEY_get1_RSA. EVP_PKEY_get1_RSA passes the caller a reference that needs to be released afterwards. BUG=393659 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M crypto/rsa_private_key_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M crypto/signature_creator_openssl.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
davidben
Verified with LSAN (would be nice to have bot coverage for that...)
6 years, 5 months ago (2014-07-14 18:18:58 UTC) #1
Ryan Sleevi
LGTM Why no BUG #?
6 years, 5 months ago (2014-07-14 18:20:09 UTC) #2
davidben
On 2014/07/14 18:20:09, Ryan Sleevi wrote: > LGTM > > Why no BUG #? Filed ...
6 years, 5 months ago (2014-07-14 18:23:38 UTC) #3
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-14 18:23:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/392653005/1
6 years, 5 months ago (2014-07-14 18:25:14 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 20:23:07 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 21:01:57 UTC) #7
Message was sent while issue was closed.
Change committed as 283020

Powered by Google App Engine
This is Rietveld 408576698