Upgrade logging to resemble base/logging.h.

Upgrade logging to resemble base/logging.h.

First phase of extending the relocation packer for arm64.

Upgrade logging to be streams-based.  Add new unit tests to cover logging
and checking features.  Mechanical changes to logging call sites.

Also correct a type promotion issue that causes incorrect DT_RELCOUNT
adjustments when the packer is compiled as a 32-bit Linux binary.

BUG=385553
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283552

[rmcilroy, 2014-07-16 11:38:48]

lgtm, thanks.

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
File tools/relocation_packer/src/debug.cc (right):

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
tools/relocation_packer/src/debug.cc:9: #include "debug.h"
nit - debug.h at the top

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
File tools/relocation_packer/src/debug.h (right):

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
tools/relocation_packer/src/debug.h:97: (relocation_packer::Logger(severity,
INT_MIN, (predicate)).GetStream())
nit - I would just use '-1' rather than INT_MIN, since that is the default.

[simonb (inactive), 2014-07-16 12:51:03]

Updates in patch set 4.  Thanks for the review.

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
File tools/relocation_packer/src/debug.cc (right):

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
tools/relocation_packer/src/debug.cc:9: #include "debug.h"
On 2014/07/16 11:38:48, rmcilroy wrote:
> nit - debug.h at the top

Done.

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
File tools/relocation_packer/src/debug.h (right):

https://codereview.chromium.org/392653002/diff/40001/tools/relocation_packer/...
tools/relocation_packer/src/debug.h:97: (relocation_packer::Logger(severity,
INT_MIN, (predicate)).GetStream())
On 2014/07/16 11:38:48, rmcilroy wrote:
> nit - I would just use '-1' rather than INT_MIN, since that is the default.

Left as is.  -1 allows (accidental?) SetVerbose(-2) or lower to suppress all log
messages, both LOG_IF and LOG.  LOG isn't supposed to be suppressable.

[simonb (inactive), 2014-07-16 13:31:42]

The CQ bit was checked by simonb@chromium.org

[commit-bot: I haz the power, 2014-07-16 13:33:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonb@chromium.org/392653002/50001

[commit-bot: I haz the power, 2014-07-16 17:08:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-16 22:38:50]

Change committed as 283552