Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: LayoutTests/inspector/console/console-viewport-selection.html

Issue 392643002: DevTools: add more logging to console-viewport-selection.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-viewport-selection-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/console/console-viewport-selection.html
diff --git a/LayoutTests/inspector/console/console-viewport-selection.html b/LayoutTests/inspector/console/console-viewport-selection.html
index e767977ce2c7833d44d5b74abe2a31518b43bdbc..1511078cad2ce3f6e3e896be51c47f42405ead0e 100644
--- a/LayoutTests/inspector/console/console-viewport-selection.html
+++ b/LayoutTests/inspector/console/console-viewport-selection.html
@@ -21,12 +21,14 @@ function test()
function verifyViewportIsTallEnough(next)
{
viewport.invalidate();
- var viewportMessagesCount = viewport._lastVisibleIndex - viewport._firstVisibleIndex;
+ viewport.forceScrollItemToBeFirst(0);
+ var viewportMessagesCount = viewport._lastVisibleIndex - viewport._firstVisibleIndex + 1;
if (viewportMessagesCount < minimumViewportMessagesCount) {
InspectorTest.addResult(String.sprintf("Test cannot be run as viewport is not tall enough. It is required to contain at least %d messages, but %d only fit", minimumViewportMessagesCount, viewportMessagesCount));
InspectorTest.completeTest();
return;
}
+ InspectorTest.addResult(String.sprintf("Viewport contains %d messages", viewportMessagesCount));
next();
},
@@ -34,6 +36,7 @@ function test()
{
selectMessages(middleMessage, 2, middleMessage, 7);
dumpSelectionText();
+ dumpBottom();
next();
},
@@ -41,6 +44,7 @@ function test()
{
selectMessages(middleMessage, 7, middleMessage, 2);
dumpSelectionText();
+ dumpBottom();
next();
},
@@ -48,6 +52,7 @@ function test()
{
selectMessages(middleMessage - 1, 4, middleMessage + 1, 7);
dumpSelectionText();
+ dumpBottom();
next();
},
« no previous file with comments | « no previous file | LayoutTests/inspector/console/console-viewport-selection-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698