Issue 39263004: Merge 229254 "Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39263004: Merge 229254 "Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES..." (Closed)

Created:
7 years, 2 months ago by no sievers

Modified:
7 years, 2 months ago

Reviewers:
no sievers

CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1650/src/

Visibility:
Public.

More Reviews

Description

Merge 229254 "Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES..." > Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES query > > glGetIntegerv(GL_TEXTURE_BINDING_EXTERNAL_OES, &texture_id) returns > GL_INVALID_ENUM on older Android NVIDIA drivers. > > The reason for the query is to restore correct texture bindings, > since SurfaceTexture.updateTexImage() implies a call to glBindTexture(). > Since we now only call this before drawing, we can just set the correct > active texture unit (which gets restored after draw). > > BUG=305526, 283053 > > Review URL: https://codereview.chromium.org/26921004 TBR=sievers@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230734

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -8 lines)			Patch
M	content/common/gpu/stream_texture_manager_android.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r230734.

Expand Messages | Collapse Messages