tools/perf/measurements/loading_trace.py - Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/loading_trace.py

Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split Start into SetUp and Start for smoothness and timeline controller. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/loading_trace.py

diff --git a/tools/perf/measurements/loading_trace.py b/tools/perf/measurements/loading_trace.py

index ed48bc06f3bd906f3c9b696d5cc51ccb77508b8e..9d926a845cf73d9b7a59de8815ccd3b0a89f22dc 100644

--- a/tools/perf/measurements/loading_trace.py

+++ b/tools/perf/measurements/loading_trace.py

@@ -17,7 +17,8 @@ class LoadingTrace(page_measurement.PageMeasurement):

return False

def WillNavigateToPage(self, page, tab):

- self._timeline_controller.Start(page, tab)

+ self._timeline_controller.SetUp(page, tab)

+ self._timeline_controller.Start(tab)

def MeasurePage(self, page, tab, results):

# In current telemetry tests, all tests wait for DocumentComplete state,

« no previous file with comments | « no previous file | tools/perf/measurements/repaint.py » ('j') | no next file with comments »