Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix testSyntheticDelayConfiguration Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/smoothness.py ('k') | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness_unittest.py
diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py
index e537399237661481f02e767b04604c9ba982a614..15c0c9caff9cabc87c5796801a40b913525c5c41 100644
--- a/tools/perf/measurements/smoothness_unittest.py
+++ b/tools/perf/measurements/smoothness_unittest.py
@@ -61,7 +61,7 @@ class SmoothnessUnitTest(
tab = FakeTab()
measurement = smoothness.Smoothness()
measurement.WillStartBrowser(tab.browser)
- measurement.WillRunActions(test_page, tab)
+ measurement.WillNavigateToPage(test_page, tab)
picksi 2014/07/18 11:30:58 Are we just moving this problem to somewhere else
Dominik Grewe 2014/07/18 16:10:51 How about we call both? :) That's what's happening
picksi 2014/07/18 16:47:20 Can it safely be doubly initialized without losing
expected_category_filter = [
'DELAY(cc.BeginMainFrame;0.012000;static)',
« no previous file with comments | « tools/perf/measurements/smoothness.py ('k') | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698