tools/perf/measurements/thread_times.py - Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/thread_times.py

Issue 392613002: Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/thread_times.py

diff --git a/tools/perf/measurements/thread_times.py b/tools/perf/measurements/thread_times.py

index 2940c86489ad49b96db88db7bca25148fb6126fa..2d1c13a2e9e3e8a0bfe70e9849325d7322ad44a8 100644

--- a/tools/perf/measurements/thread_times.py

+++ b/tools/perf/measurements/thread_times.py

@@ -22,7 +22,7 @@ class ThreadTimes(page_measurement.PageMeasurement):

def results_are_the_same_on_every_page(self):

return False

- def WillRunActions(self, page, tab):

+ def WillNavigateToPage(self, page, tab):

self._timeline_controller = timeline_controller.TimelineController()

if self.options.report_silk_details:

# We need the other traces in order to have any details to report.

« tools/perf/measurements/smoothness.py ('K') | « tools/perf/measurements/smoothness.py ('k') | no next file » | no next file with comments »