DevTools: refactoring connection creation, removing a couple of dead code branches.

Source/devtools/front_end/sdk/InspectorBackend.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 540 matching lines @@
         console.log(message);
     },
 
     __proto__: WebInspector.Object.prototype
 
 }
 
 /**
  * @constructor
  * @extends {InspectorBackendClass.Connection}
- * @param {!function(!InspectorBackendClass.Connection)} onConnectionReady
  */
-InspectorBackendClass.MainConnection = function(onConnectionReady)
+InspectorBackendClass.MainConnection = function()
 {
     InspectorBackendClass.Connection.call(this);
-    onConnectionReady(this);
     InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.DispatchMessage, this._dispatchMessage, this);
 }
 
 InspectorBackendClass.MainConnection.prototype = {
 
     /**
      * @param {!Object} messageObject
      */
     sendMessage: function(messageObject)
     {
@@ skipping 21 matching lines @@
 InspectorBackendClass.WebSocketConnection = function(url, onConnectionReady)
 {
     InspectorBackendClass.Connection.call(this);
     this._socket = new WebSocket(url);
     this._socket.onmessage = this._onMessage.bind(this);
     this._socket.onerror = this._onError.bind(this);
     this._socket.onopen = onConnectionReady.bind(null, this);
     this._socket.onclose = this.fireDisconnected.bind(this, "websocket_closed");
 }
 
+/**
+ * @param {string} url
+ * @param {!function(!InspectorBackendClass.Connection)} onConnectionReady
+ */
+InspectorBackendClass.WebSocketConnection.Create = function(url, onConnectionReady)
+{
+    new InspectorBackendClass.WebSocketConnection(url, onConnectionReady);
+}
+
 InspectorBackendClass.WebSocketConnection.prototype = {
 
     /**
      * @param {!MessageEvent} message
      */
     _onMessage: function(message)
     {
         var data = /** @type {string} */ (message.data)
         this.dispatch(data);
     },
@@ skipping 15 matching lines @@
         this._socket.send(message);
     },
 
     __proto__: InspectorBackendClass.Connection.prototype
 }
 
 
 /**
  * @constructor
  * @extends {InspectorBackendClass.Connection}
- * @param {!function(!InspectorBackendClass.Connection)} onConnectionReady
  */
-InspectorBackendClass.StubConnection = function(onConnectionReady)
+InspectorBackendClass.StubConnection = function()
 {
     InspectorBackendClass.Connection.call(this);
-    onConnectionReady(this);
 }
 
 InspectorBackendClass.StubConnection.prototype = {
 
     /**
      * @param {!Object} messageObject
      */
     sendMessage: function(messageObject)
     {
         var message = JSON.stringify(messageObject);
@@ skipping 219 matching lines @@
 
 }
 
 InspectorBackendClass.Options = {
     dumpInspectorTimeStats: false,
     dumpInspectorProtocolMessages: false,
     suppressRequestErrors: false
 }
 
 InspectorBackend = new InspectorBackendClass();