Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: Source/devtools/front_end/main/AdvancedApp.js

Issue 392603002: DevTools: refactoring connection creation, removing a couple of dead code branches. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/inspector.css ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.App} 7 * @extends {WebInspector.App}
8 */ 8 */
9 WebInspector.AdvancedApp = function() 9 WebInspector.AdvancedApp = function()
10 { 10 {
11 WebInspector.App.call(this); 11 WebInspector.App.call(this);
12 WebInspector.dockController.addEventListener(WebInspector.DockController.Eve nts.BeforeDockSideChanged, this._openToolboxWindow, this); 12 WebInspector.dockController.addEventListener(WebInspector.DockController.Eve nts.BeforeDockSideChanged, this._openToolboxWindow, this);
13 }; 13 };
14 14
15 WebInspector.AdvancedApp.prototype = { 15 WebInspector.AdvancedApp.prototype = {
16 createRootView: function() 16 createRootView: function()
17 { 17 {
18 var rootView = new WebInspector.RootView(); 18 var rootView = new WebInspector.RootView();
19 19
20 this._rootSplitView = new WebInspector.SplitView(false, true, WebInspect or.dockController.canDock() ? "InspectorView.splitViewState" : "InspectorView.du mmySplitViewState", 300, 300, true); 20 this._rootSplitView = new WebInspector.SplitView(false, true, "Inspector View.splitViewState", 300, 300, true);
21 this._rootSplitView.show(rootView.element); 21 this._rootSplitView.show(rootView.element);
22 22
23 WebInspector.inspectorView.show(this._rootSplitView.sidebarElement()); 23 WebInspector.inspectorView.show(this._rootSplitView.sidebarElement());
24 24
25 this._inspectedPagePlaceholder = new WebInspector.InspectedPagePlacehold er(); 25 this._inspectedPagePlaceholder = new WebInspector.InspectedPagePlacehold er();
26 this._inspectedPagePlaceholder.addEventListener(WebInspector.InspectedPa gePlaceholder.Events.Update, this._onSetInspectedPageBounds.bind(this, false), t his); 26 this._inspectedPagePlaceholder.addEventListener(WebInspector.InspectedPa gePlaceholder.Events.Update, this._onSetInspectedPageBounds.bind(this, false), t his);
27 this._responsiveDesignView = new WebInspector.ResponsiveDesignView(this. _inspectedPagePlaceholder); 27 this._responsiveDesignView = new WebInspector.ResponsiveDesignView(this. _inspectedPagePlaceholder);
28 this._responsiveDesignView.show(this._rootSplitView.mainElement()); 28 this._responsiveDesignView.show(this._rootSplitView.mainElement());
29 29
30 WebInspector.dockController.addEventListener(WebInspector.DockController .Events.BeforeDockSideChanged, this._onBeforeDockSideChange, this); 30 WebInspector.dockController.addEventListener(WebInspector.DockController .Events.BeforeDockSideChanged, this._onBeforeDockSideChange, this);
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 178
179 var advancedApp = /** @type {!WebInspector.AdvancedApp} */ (window.opener.We bInspector.app); 179 var advancedApp = /** @type {!WebInspector.AdvancedApp} */ (window.opener.We bInspector.app);
180 var rootView = new WebInspector.RootView(); 180 var rootView = new WebInspector.RootView();
181 this._inspectedPagePlaceholder = new WebInspector.InspectedPagePlaceholder() ; 181 this._inspectedPagePlaceholder = new WebInspector.InspectedPagePlaceholder() ;
182 this._inspectedPagePlaceholder.addEventListener(WebInspector.InspectedPagePl aceholder.Events.Update, advancedApp._onSetInspectedPageBounds.bind(advancedApp, true)); 182 this._inspectedPagePlaceholder.addEventListener(WebInspector.InspectedPagePl aceholder.Events.Update, advancedApp._onSetInspectedPageBounds.bind(advancedApp, true));
183 this._responsiveDesignView = new WebInspector.ResponsiveDesignView(this._ins pectedPagePlaceholder); 183 this._responsiveDesignView = new WebInspector.ResponsiveDesignView(this._ins pectedPagePlaceholder);
184 this._responsiveDesignView.show(rootView.element); 184 this._responsiveDesignView.show(rootView.element);
185 rootView.attachToBody(); 185 rootView.attachToBody();
186 advancedApp._toolboxLoaded(this); 186 advancedApp._toolboxLoaded(this);
187 } 187 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/inspector.css ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698