Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 392603002: DevTools: refactoring connection creation, removing a couple of dead code branches. (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
Reviewers:
dgozman, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: refactoring connection creation, removing a couple of dead code branches. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -47 lines) Patch
M Source/devtools/front_end/inspector.css View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/main/Main.js View 4 chunks +25 lines, -29 lines 0 comments Download
M Source/devtools/front_end/sdk/InspectorBackend.js View 3 chunks +11 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkerManager.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pfeldman
6 years, 5 months ago (2014-07-14 13:40:12 UTC) #1
sergeyv
lgtm
6 years, 5 months ago (2014-07-14 13:45:12 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-14 15:23:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/392603002/1
6 years, 5 months ago (2014-07-14 15:24:12 UTC) #4
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-14 16:21:41 UTC) #5
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-14 16:21:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/392603002/1
6 years, 5 months ago (2014-07-14 16:21:49 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 16:22:20 UTC) #8
Message was sent while issue was closed. 
Change committed as 178072

Powered by Google App Engine
This is Rietveld 408576698