Issue 392593002: Reallow default SkPicture constructor for Chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 392593002: Reallow default SkPicture constructor for Chromium (Closed)

Created:
6 years, 5 months ago by robertphillips

Modified:
6 years, 5 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Reallow default SkPicture constructor for Chromium This is breaking the Chromium build in: external/chromium_org/android_webview/browser/browser_view_renderer.cc TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/4fdba1c

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gyp/skia_for_chromium_defines.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 5 months ago (2014-07-14 13:09:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/392593002/1

6 years, 5 months ago (2014-07-14 13:10:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r4fdba1c.