Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 392583005: nanobench: add --runOnce. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
egdaniel, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : do less #

Patch Set 3 : add a note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M bench/nanobench.cpp View 1 2 6 chunks +37 lines, -17 lines 0 comments Download
M tools/Stats.h View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 5 months ago (2014-07-14 18:46:22 UTC) #1
egdaniel
lgtm + possible suggestion In debug mode you should probably have some message print out ...
6 years, 5 months ago (2014-07-14 19:01:03 UTC) #2
mtklein
On 2014/07/14 19:01:03, egdaniel wrote: > lgtm + possible suggestion > > In debug mode ...
6 years, 5 months ago (2014-07-14 19:08:23 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-14 19:08:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/392583005/40001
6 years, 5 months ago (2014-07-14 19:09:33 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 19:28:55 UTC) #6
Message was sent while issue was closed.
Change committed as a189ccdb4d5efdbbfa34a26c08656634b615f930

Powered by Google App Engine
This is Rietveld 408576698