Source/core/html/HTMLTextAreaElement.h - Issue 392573002: HTMLTextAreaElement.setSelectionRange should not change focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.h

Issue 392573002: HTMLTextAreaElement.setSelectionRange should not change focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix tests Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/text/international/mixed-directionality-selection.html ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextAreaElement.h

diff --git a/Source/core/html/HTMLTextAreaElement.h b/Source/core/html/HTMLTextAreaElement.h

index 290e109ca74f37aec8f97cd9162be43fe69ba0e8..b5f9ffb4b5f7320263d27d014696545f513cf86c 100644

--- a/Source/core/html/HTMLTextAreaElement.h

+++ b/Source/core/html/HTMLTextAreaElement.h

@@ -76,7 +76,7 @@ private:

void updateValue() const;

virtual void setInnerEditorValue(const String&) OVERRIDE;

void setNonDirtyValue(const String&);

- void setValueCommon(const String&, TextFieldEventBehavior);

+ void setValueCommon(const String&, TextFieldEventBehavior, SelectionOption = NotChangeSelection);

virtual bool supportsPlaceholder() const OVERRIDE { return true; }

virtual void updatePlaceholderText() OVERRIDE;