Source/core/html/HTMLTextAreaElement.h - Issue 392573002: HTMLTextAreaElement.setSelectionRange should not change focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.h

Issue 392573002: HTMLTextAreaElement.setSelectionRange should not change focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rename Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/text/international/mixed-directionality-selection.html ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | Source/core/html/HTMLTextFormControlElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextAreaElement.h

diff --git a/Source/core/html/HTMLTextAreaElement.h b/Source/core/html/HTMLTextAreaElement.h

index d0e86887aeddd82ede8bd53014ee0ee8c6c950ce..aeeffea63bd9e1b52eb439401b95996c6d7a5a21 100644

--- a/Source/core/html/HTMLTextAreaElement.h

+++ b/Source/core/html/HTMLTextAreaElement.h

@@ -76,7 +76,7 @@ private:

void updateValue() const;

virtual void setInnerEditorValue(const String&) OVERRIDE;

void setNonDirtyValue(const String&);

- void setValueCommon(const String&, TextFieldEventBehavior);

+ bool setValueCommon(const String&, TextFieldEventBehavior);

yosin_UTC9 2014/07/16 07:09:14 nit: Could you add comment about |bool| return val

yoichio 2014/07/16 08:07:12 Done.

virtual bool supportsPlaceholder() const OVERRIDE { return true; }

virtual void updatePlaceholderText() OVERRIDE;