HTMLTextAreaElement.setSelectionRange should not change focus.

Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 16 matching lines @@
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
 #include "core/HTMLNames.h"
 #include "core/accessibility/AXObjectCache.h"
 #include "core/dom/Document.h"
 #include "core/dom/NodeList.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/Text.h"
 #include "core/dom/shadow/ShadowRoot.h"
+#include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/TextIterator.h"
 #include "core/events/Event.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLBRElement.h"
 #include "core/html/shadow/ShadowElementNames.h"
 #include "core/rendering/RenderBlock.h"
 #include "core/rendering/RenderTheme.h"
 #include "platform/heap/Handle.h"
@@ skipping 126 matching lines @@
     setSelectionRange(std::min(end, selectionStart()), end, selectionDirection());
 }
 
 void HTMLTextFormControlElement::setSelectionDirection(const String& direction)
 {
     setSelectionRange(selectionStart(), selectionEnd(), direction);
 }
 
 void HTMLTextFormControlElement::select()
 {
-    setSelectionRange(0, std::numeric_limits<int>::max(), SelectionHasNoDirection);
+    setSelectionRange(0, std::numeric_limits<int>::max(), SelectionHasNoDirection, MustFocus);

[tkent, 2014/07/16 07:11:34]

Is this compatible with other browsers?
Can we add focus() before setSelectionRange, and remove MustFocus flag?

[yoichio, 2014/07/16 08:07:12]

Both FF and IE do.
To add focus() and call FrameSelection::setSelection with DoNotSetFocus doesn't
work.
If we should do, we need extra investigation.

[tkent, 2014/07/16 23:34:16]

Please have an investigation.
Adding no flag is simpler and better.

 }
 
 bool HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(String& oldValue, String& newValue)
 {
     return !equalIgnoringNullity(oldValue, newValue);
 }
 
 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
 {
     String newValue = value();
@@ skipping 73 matching lines @@
 }
 
 void HTMLTextFormControlElement::setSelectionRange(int start, int end, const String& directionString)
 {
     TextFieldSelectionDirection direction = SelectionHasNoDirection;
     if (directionString == "forward")
         direction = SelectionHasForwardDirection;
     else if (directionString == "backward")
         direction = SelectionHasBackwardDirection;
 
+    if (direction == SelectionHasNoDirection && document().frame() && document().frame()->editor().behavior().shouldConsiderSelectionAsDirectional())
+        direction = SelectionHasForwardDirection;
+
     return setSelectionRange(start, end, direction);
 }
 
-void HTMLTextFormControlElement::setSelectionRange(int start, int end, TextFieldSelectionDirection direction)
+void HTMLTextFormControlElement::setSelectionRange(int start, int end, TextFieldSelectionDirection direction, FocusOption focusOption)
 {
     document().updateLayoutIgnorePendingStylesheets();
 
     if (!renderer() || !renderer()->isTextControl())
         return;
 
     int textLength = innerEditorValue().length();
     end = std::max(std::min(end, textLength), 0);
     start = std::max(std::min(start, end), 0);
     cacheSelection(start, end, direction);
-    bool isCaretSelection = start == end;
-    bool shouldSetSelection = document().focusedElement() == this || (!isCaretSelection && start < textLength);
-
-    if (!hasVisibleTextArea(renderer(), innerEditorElement()))
+    if (focusOption != MustFocus && (document().focusedElement() != this || !hasVisibleTextArea(renderer(), innerEditorElement())))
         return;
 
     LocalFrame* frame = document().frame();

[yosin_UTC9, 2014/07/16 07:09:14]

nit: You can move |!frame| before L286.

[yoichio, 2014/07/16 08:07:12]

Done.

 
-    if (!frame || !shouldSetSelection)
+    if (!frame)
         return;
 
     VisiblePosition startPosition = visiblePositionForIndex(start);
     VisiblePosition endPosition;
     if (start == end)
         endPosition = startPosition;
     else
         endPosition = visiblePositionForIndex(end);
 
     // startPosition and endPosition can be null position for example when
     // "-webkit-user-select: none" style attribute is specified.
     if (startPosition.isNotNull() && endPosition.isNotNull()) {
         ASSERT(startPosition.deepEquivalent().deprecatedNode()->shadowHost() == this
             && endPosition.deepEquivalent().deprecatedNode()->shadowHost() == this);
     }
     VisibleSelection newSelection;
     if (direction == SelectionHasBackwardDirection)
         newSelection = VisibleSelection(endPosition, startPosition);
     else
         newSelection = VisibleSelection(startPosition, endPosition);
     newSelection.setIsDirectional(direction != SelectionHasNoDirection);
 
     frame->selection().setSelection(newSelection);

[tkent, 2014/07/16 07:11:34]

We should pass DoNotSetFocus option, IMO.

[yoichio, 2014/07/16 08:07:12]

Acknowledged.

 }
 
 VisiblePosition HTMLTextFormControlElement::visiblePositionForIndex(int index) const
 {
     if (index <= 0)
         return VisiblePosition(firstPositionInNode(innerEditorElement()), DOWNSTREAM);
     RefPtrWillBeRawPtr<Range> range = Range::create(document());
     range->selectNodeContents(innerEditorElement(), ASSERT_NO_EXCEPTION);
     CharacterIterator it(range.get());
     it.advance(index - 1);
@@ skipping 568 matching lines @@
             Text* textNode = toText(node);
             size_t firstLineBreak = textNode->data().find('\n', isPivotNode ? pivotPosition.offsetInContainerNode() : 0);
             if (firstLineBreak != kNotFound)
                 return Position(textNode, firstLineBreak + 1);
         }
     }
     return endOfInnerText(textFormControl);
 }
 
 } // namespace Webcore