Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: pkg/source_maps/lib/span.dart

Issue 392563003: Fix class implementing FormatException getting warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/source_maps/pubspec.yaml » ('j') | pkg/source_maps/pubspec.yaml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/source_maps/lib/span.dart
diff --git a/pkg/source_maps/lib/span.dart b/pkg/source_maps/lib/span.dart
index 600506ee1e4323591ede8705eae5b9ece702c35f..771e9e0efa2804c58d93de49353902362d09fadc 100644
--- a/pkg/source_maps/lib/span.dart
+++ b/pkg/source_maps/lib/span.dart
@@ -387,4 +387,7 @@ class SpanException implements Exception {
class SpanFormatException extends SpanException implements FormatException {
SpanFormatException(String message, Span span)
: super(message, span);
+
+ get source => null;
nweiz 2014/07/14 19:24:15 This should be "span == null ? null : span.sourceU
nweiz 2014/07/14 19:35:51 I just looked at the source of FormatException and
Lasse Reichstein Nielsen 2014/07/15 09:19:48 Done. I have added the field, with an optional con
+ int get position => null;
nweiz 2014/07/14 19:24:15 This should be "span == null ? null : span.start.o
Lasse Reichstein Nielsen 2014/07/15 09:19:48 Done.
}
« no previous file with comments | « no previous file | pkg/source_maps/pubspec.yaml » ('j') | pkg/source_maps/pubspec.yaml » ('J')

Powered by Google App Engine
This is Rietveld 408576698