Issue 392543002: Gallery.app: Add shortcut keys for zooming in the slide mode.

Issue 392543002: Gallery.app: Add shortcut keys for zooming in the slide mode. (Closed)

Created:
6 years, 5 months ago by hirono

Modified:
6 years, 5 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Gallery.app: Add shortcut keys for zooming in the slide mode. The zoom is reset when it goes into the edit/mosaic/slideshow modes. BUG=245926 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282930

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed. #

Total comments: 2

Patch Set 3 : Fixed. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -2 lines)			Patch
	M	ui/file_manager/gallery/js/image_editor/viewport.js	View	1 2	4 chunks	+54 lines, -1 line	0 comments	Download
	M	ui/file_manager/gallery/js/slide_mode.js	View		4 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yoshiki

https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js File ui/file_manager/gallery/js/image_editor/viewport.js (right): https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js#newcode59 ui/file_manager/gallery/js/image_editor/viewport.js:59: * @type {Map.<number, number>} <string, number>? https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js#newcode105 ui/file_manager/gallery/js/image_editor/viewport.js:105: * ...

6 years, 5 months ago (2014-07-14 07:27:20 UTC) #2

hirono

Thank you! https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js File ui/file_manager/gallery/js/image_editor/viewport.js (right): https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js#newcode59 ui/file_manager/gallery/js/image_editor/viewport.js:59: * @type {Map.<number, number>} On 2014/07/14 07:27:20, ...

6 years, 5 months ago (2014-07-14 07:30:06 UTC) #3

yoshiki

lgtm with nits https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js File ui/file_manager/gallery/js/image_editor/viewport.js (right): https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js#newcode96 ui/file_manager/gallery/js/image_editor/viewport.js:96: if (!Viewport.ZOOM_RATIOS[zoomIndex]) nit: Using toString() method ...

6 years, 5 months ago (2014-07-14 07:34:59 UTC) #4

hirono

Thank you! https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js File ui/file_manager/gallery/js/image_editor/viewport.js (right): https://codereview.chromium.org/392543002/diff/1/ui/file_manager/gallery/js/image_editor/viewport.js#newcode96 ui/file_manager/gallery/js/image_editor/viewport.js:96: if (!Viewport.ZOOM_RATIOS[zoomIndex]) On 2014/07/14 07:34:58, yoshiki wrote: ...

6 years, 5 months ago (2014-07-14 08:10:00 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/392543002/40001

6 years, 5 months ago (2014-07-14 08:10:34 UTC) #7

Message was sent while issue was closed.

Change committed as 282930

Expand Messages | Collapse Messages