Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
392533002:
Hookup the PDF extension to the chrome extensions zoom API (Closed)
|
Created:
6 years, 5 months ago by raymes Modified:
6 years, 5 months ago CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionHookup the PDF extension to the chrome extensions zoom API
BUG=303491
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283225
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284025
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 17 (0 generated)
lgtm
The CQ bit was checked by raymes@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/392533002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
Message was sent while issue was closed.
Change committed as 283225
On 2014/07/15 19:00:47, I haz the power (commit-bot) wrote: > Change committed as 283225 This looks like it broke browsertests: PDFExtensionTest.Basic PDFExtensionTest.BasicPlugin PDFExtensionTest.Viewport Links: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/... http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/... Excerpt from log: PDFExtensionTest.Basic (run #1): [ RUN ] PDFExtensionTest.Basic [2444:3504:0715/193333:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [2444:6108:0715/193335:ERROR:ipc_channel_win.cc(166)] pipe error: 109 [3560:5592:0715/193335:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [4448:3696:0715/193335:INFO:CONSOLE(0)] "Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self' chrome-extension-resource:". ", source: (0) [4448:3696:0715/193335:INFO:CONSOLE(0)] "Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self' chrome-extension-resource:". ", source: (0) [3560:5592:0715/193337:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully. [3560:5592:0715/193337:ERROR:pepper_uma_host.cc(107)] Host or histogram name is not allowed to use the UMA API. [3560:5592:0715/193337:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully. [4448:3696:0715/193337:INFO:CONSOLE(0)] "[SUCCESS] testHasElements", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://127.0.0.1:64162/pdf/test.pdf (0) [3560:5592:0715/193337:INFO:skpicturerecord.h(271)] e:\b\build\slave\win-latest-dbg\build\src\third_party\skia\src\core\skpicturerecord.h:271: failed assertion "flat.isTopBotWritten()"
On 2014/07/16 03:51:59, falken wrote: > On 2014/07/15 19:00:47, I haz the power (commit-bot) wrote: > > Change committed as 283225 > > This looks like it broke browsertests: > PDFExtensionTest.Basic > PDFExtensionTest.BasicPlugin > PDFExtensionTest.Viewport > > Links: > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... > http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/... > http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/... > > Excerpt from log: > PDFExtensionTest.Basic (run #1): > [ RUN ] PDFExtensionTest.Basic > [2444:3504:0715/193333:ERROR:singleton_hwnd.cc(43)] Cannot create windows on > non-UI thread! > [2444:6108:0715/193335:ERROR:ipc_channel_win.cc(166)] pipe error: 109 > [3560:5592:0715/193335:ERROR:singleton_hwnd.cc(43)] Cannot create windows on > non-UI thread! > [4448:3696:0715/193335:INFO:CONSOLE(0)] "Refused to evaluate a string as > JavaScript because 'unsafe-eval' is not an allowed source of script in the > following Content Security Policy directive: "script-src 'self' > chrome-extension-resource:". > ", source: (0) > [4448:3696:0715/193335:INFO:CONSOLE(0)] "Refused to evaluate a string as > JavaScript because 'unsafe-eval' is not an allowed source of script in the > following Content Security Policy directive: "script-src 'self' > chrome-extension-resource:". > ", source: (0) > [3560:5592:0715/193337:WARNING:resource_message_handler.cc(49)] 'Post' message > handler failed to complete successfully. > [3560:5592:0715/193337:ERROR:pepper_uma_host.cc(107)] Host or histogram name is > not allowed to use the UMA API. > [3560:5592:0715/193337:WARNING:resource_message_handler.cc(49)] 'Post' message > handler failed to complete successfully. > [4448:3696:0715/193337:INFO:CONSOLE(0)] "[SUCCESS] testHasElements", source: > chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://127.0.0.1:64162/pdf/test.pdf > (0) > [3560:5592:0715/193337:INFO:skpicturerecord.h(271)] > e:\b\build\slave\win-latest-dbg\build\src\third_party\skia\src\core\skpicturerecord.h:271: > failed assertion "flat.isTopBotWritten()" Now I see this was reverted in: https://codereview.chromium.org/398643002
On 2014/07/16 03:54:38, falken wrote: > On 2014/07/16 03:51:59, falken wrote: > > On 2014/07/15 19:00:47, I haz the power (commit-bot) wrote: > > > Change committed as 283225 > > > > This looks like it broke browsertests: > > PDFExtensionTest.Basic > > PDFExtensionTest.BasicPlugin > > PDFExtensionTest.Viewport /* snip */ > Now I see this was reverted in: > https://codereview.chromium.org/398643002 Except... that revision (r283269) for the revert should have appeared in http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... but it didn't go green and the blamelist jumps from r283265 to r283275 o_O. Very peculiar. I've tried queuing up a clobber on the bot (but I think that feature is broken :/). Will keep an eye on it anyway.
On 2014/07/16 04:10:17, tapted wrote: > On 2014/07/16 03:54:38, falken wrote: > > On 2014/07/16 03:51:59, falken wrote: > > > On 2014/07/15 19:00:47, I haz the power (commit-bot) wrote: > > > > Change committed as 283225 > > > > > > This looks like it broke browsertests: > > > PDFExtensionTest.Basic > > > PDFExtensionTest.BasicPlugin > > > PDFExtensionTest.Viewport > /* snip */ > > Now I see this was reverted in: > > https://codereview.chromium.org/398643002 > > Except... that revision (r283269) for the revert should have appeared in > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... > but it didn't go green and the blamelist jumps from r283265 to r283275 o_O. Very > peculiar. I've tried queuing up a clobber on the bot (but I think that feature > is broken :/). Will keep an eye on it anyway. Hmm the tests are still failing: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... And a lot on chromium.webkit, e.g.: http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/...
On 2014/07/16 08:50:46, falken wrote: > On 2014/07/16 04:10:17, tapted wrote: > > On 2014/07/16 03:54:38, falken wrote: > > > On 2014/07/16 03:51:59, falken wrote: > > > > On 2014/07/15 19:00:47, I haz the power (commit-bot) wrote: > > > > > Change committed as 283225 > > > > > > > > This looks like it broke browsertests: > > > > PDFExtensionTest.Basic > > > > PDFExtensionTest.BasicPlugin > > > > PDFExtensionTest.Viewport > > /* snip */ > > > Now I see this was reverted in: > > > https://codereview.chromium.org/398643002 > > > > Except... that revision (r283269) for the revert should have appeared in > > > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... > > but it didn't go green and the blamelist jumps from r283265 to r283275 o_O. > Very > > peculiar. I've tried queuing up a clobber on the bot (but I think that feature > > is broken :/). Will keep an eye on it anyway. > > Hmm the tests are still failing: > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... > > And a lot on chromium.webkit, e.g.: > http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/... The failure is tracked on crbug.com/394267. It looks like another patch caused it. I think I accidentally re-opened this issue, marking as closed again.
On 2014/07/17 07:10:54, falken wrote: > On 2014/07/16 08:50:46, falken wrote: > > On 2014/07/16 04:10:17, tapted wrote: > > > On 2014/07/16 03:54:38, falken wrote: > > > > On 2014/07/16 03:51:59, falken wrote: > > > > > On 2014/07/15 19:00:47, I haz the power (commit-bot) wrote: > > > > > > Change committed as 283225 > > > > > > > > > > This looks like it broke browsertests: > > > > > PDFExtensionTest.Basic > > > > > PDFExtensionTest.BasicPlugin > > > > > PDFExtensionTest.Viewport > > > /* snip */ > > > > Now I see this was reverted in: > > > > https://codereview.chromium.org/398643002 > > > > > > Except... that revision (r283269) for the revert should have appeared in > > > > > > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... > > > but it didn't go green and the blamelist jumps from r283265 to r283275 o_O. > > Very > > > peculiar. I've tried queuing up a clobber on the bot (but I think that > feature > > > is broken :/). Will keep an eye on it anyway. > > > > Hmm the tests are still failing: > > > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28... > > > > And a lot on chromium.webkit, e.g.: > > > http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/... > > The failure is tracked on crbug.com/394267. It looks like another patch caused > it. I think I accidentally re-opened this issue, marking as closed again. Thanks falken@, I'm going to try relanding.
The CQ bit was checked by raymes@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/392533002/40001
On 2014/07/18 00:25:20, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://chromium-status.appspot.com/cq/raymes@chromium.org/392533002/40001 LGTM
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
Message was sent while issue was closed.
Change committed as 284025 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
