Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 392523002: Document.body should check interface type and be nullable (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Document.body should check interface type and be nullable SPEC: http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#document This CL enabled an interface type checking on setter of Document.body and a nullable type to body attribute as per specification. In addition, with this change, a failed test case will be passed in http://w3c-test.org/html/dom/documents/dom-tree-accessors/document.body-setter-01.html TEST=LayoutTests/fast/dom/setter-type-enforcement.html Behavior in other browsers: *)FF: PASS *)IE: FAIL Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M LayoutTests/fast/dom/setter-type-enforcement-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kangil_
PTAL
6 years, 5 months ago (2014-07-14 07:31:32 UTC) #1
haraken
Can we remove some code from Document.cpp that had been used to throw the HierarchyRequestError ...
6 years, 5 months ago (2014-07-14 07:44:12 UTC) #2
kangil_
On 2014/07/14 07:44:12, haraken wrote: > Can we remove some code from Document.cpp that had ...
6 years, 5 months ago (2014-07-14 08:04:43 UTC) #3
haraken
On 2014/07/14 08:04:43, kangil_ wrote: > On 2014/07/14 07:44:12, haraken wrote: > > Can we ...
6 years, 5 months ago (2014-07-14 08:10:24 UTC) #4
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-14 08:15:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/392523002/1
6 years, 5 months ago (2014-07-14 08:16:33 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 09:22:13 UTC) #7
Message was sent while issue was closed.
Change committed as 178039

Powered by Google App Engine
This is Rietveld 408576698