Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 392503002: webkit: Cleanup webkit_common target. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin (slow to review), jam
Project:
chromium
Visibility:
Public.

Description

webkit: Cleanup webkit_common target. This removes all the unnecessary stuff. Only base and url libraries are necessary to compile data_element.cc. BUG=None TEST=None R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -55 lines) Patch
M webkit/common/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M webkit/common/webkit_common.gyp View 1 chunk +2 lines, -41 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Is this cleanup fine?
6 years, 5 months ago (2014-07-14 03:22:18 UTC) #1
jamesr
lgtm Cool!
6 years, 5 months ago (2014-07-14 05:53:14 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-14 13:42:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/392503002/1
6 years, 5 months ago (2014-07-14 13:42:47 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 14:31:05 UTC) #5
Message was sent while issue was closed.
Change committed as 282945

Powered by Google App Engine
This is Rietveld 408576698