Issue 39248: Make both Hebrew Visual (ISO-8859-8) and Hebrew Logical (ISO-8859-8-I)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39248: Make both Hebrew Visual (ISO-8859-8) and Hebrew Logical (ISO-8859-8-I)... (Closed)

Created:
11 years, 9 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Johnny(Jianning) Ding, jnd

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make both Hebrew Visual (ISO-8859-8) and Hebrew Logical (ISO-8859-8-I) available in the encoding menu. Make windows-1255 come before ISO-8859-8* both in the full encoding list and in Hebew Chrome's static list. BUG=2927 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11180

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	chrome/app/chrome_dll_resource.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/app/resources/locale_settings_he.xtb	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/character_encoding.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/encoding_menu_controller_delegate.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Johnny(Jianning) Ding

11 years, 9 months ago (2009-03-06 07:46:21 UTC) #2

LGTM.
Only two minor issues need to be done before you commit

http://codereview.chromium.org/39248/diff/1/6
File chrome/browser/character_encoding.cc (right):

http://codereview.chromium.org/39248/diff/1/6#newcode59
Line 59: { IDC_ENCODING_ISO88598I, L"ISO-8859-8-I", IDS_ENCODING_HEBREW },
Please make sure the encoding sequence changes also happen on the below
default_encoding_menus. Also please add "ISO-8859-8-I" to default_encoding_menus
array.

Expand Messages | Collapse Messages