Issue 392443002: update deep-memory-profiler policy for webcore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 392443002: update deep-memory-profiler policy for webcore. (Closed)

Created:
6 years, 5 months ago by JungJik

Modified:
6 years, 5 months ago

Reviewers:
Dai Mikurube (NOT FULLTIME)

CC:
chromium-reviews, dmikurube+memory_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

update deep-memory-profiler policy for webcore. ScriptExecute has changed to ScriptLoader. (crrev.com/18261015) HTMLElement::setInnerHTML has changed to Element:setInnerHTML. (crrev.com/44333002) CachedResource has changed to ResourceFetcher with cached property. Node::createRendererIfNeeded is deprecated and replaced to [a-zA-Z0-9_]*Element::createRender. Bug=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282911

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -58 lines)			Patch
M	tools/deep_memory_profiler/policy.android.renderer.json	View	1 2	4 chunks	+8 lines, -13 lines	0 comments	Download
M	tools/deep_memory_profiler/policy.android.webview.json	View	1 2	4 chunks	+8 lines, -13 lines	0 comments	Download
M	tools/deep_memory_profiler/policy.l2.json	View	1 2	4 chunks	+8 lines, -13 lines	0 comments	Download
M	tools/deep_memory_profiler/sorter.malloc-component.json	View	1 2	4 chunks	+9 lines, -12 lines	0 comments	Download
M	tools/deep_memory_profiler/sorters/malloc.WebCore.json	View	1 2	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

JungJik

On 2014/07/14 07:04:18, Dai Mikurube wrote: > Thanks! lgtm. Thanks for lgtm :)

6 years, 5 months ago (2014-07-14 07:17:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/392443002/40001

6 years, 5 months ago (2014-07-14 07:17:54 UTC) #5

Message was sent while issue was closed.

Change committed as 282911

Expand Messages | Collapse Messages