Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 392403003: Remove unneeded break in CompositedLayerMapping::containingSquashedLayer (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unneeded break in CompositedLayerMapping::containingSquashedLayer Remove unneeded break because the return makes it unreachable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178357

Patch Set 1 #

Patch Set 2 : Add braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-16 19:42:42 UTC) #1
Ian Vollick
On 2014/07/16 19:42:42, rwlbuis wrote: > PTAL lgtm.
6 years, 5 months ago (2014-07-16 19:45:45 UTC) #2
Ian Vollick
On 2014/07/16 19:45:45, Ian Vollick wrote: > On 2014/07/16 19:42:42, rwlbuis wrote: > > PTAL ...
6 years, 5 months ago (2014-07-16 19:47:45 UTC) #3
rwlbuis
On 2014/07/16 19:47:45, Ian Vollick wrote: > On 2014/07/16 19:45:45, Ian Vollick wrote: > > ...
6 years, 5 months ago (2014-07-16 19:54:07 UTC) #4
Ian Vollick
On 2014/07/16 19:54:07, rwlbuis wrote: > On 2014/07/16 19:47:45, Ian Vollick wrote: > > On ...
6 years, 5 months ago (2014-07-16 19:56:03 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-16 20:01:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/392403003/20001
6 years, 5 months ago (2014-07-16 20:02:04 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-16 21:07:43 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 22:03:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17348)
6 years, 5 months ago (2014-07-16 22:03:11 UTC) #10
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-17 09:38:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/392403003/20001
6 years, 5 months ago (2014-07-17 09:38:22 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 11:10:42 UTC) #13
Message was sent while issue was closed.
Change committed as 178357

Powered by Google App Engine
This is Rietveld 408576698