Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 392343002: Cleanup of class id loading sequences. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
===================================================================
--- runtime/vm/stub_code_x64.cc (revision 38317)
+++ runtime/vm/stub_code_x64.cc (working copy)
@@ -1271,8 +1271,7 @@
if (FLAG_enable_debugger) {
// Check single stepping.
__ movq(RAX, FieldAddress(CTX, Context::isolate_offset()));
- __ movzxb(RAX, Address(RAX, Isolate::single_step_offset()));
- __ cmpq(RAX, Immediate(0));
+ __ cmpb(Address(RAX, Isolate::single_step_offset()), Immediate(0));
__ j(NOT_EQUAL, &stepping);
__ Bind(&done_stepping);
}
@@ -1290,8 +1289,8 @@
// Get the receiver's class ID (first read number of arguments from
// arguments descriptor array and then access the receiver from the stack).
__ movq(RAX, FieldAddress(R10, ArgumentsDescriptor::count_offset()));
- __ movq(RAX, Address(RSP, RAX, TIMES_4, 0)); // RAX (argument count) is Smi.
- __ LoadTaggedClassIdMayBeSmi(RAX, RAX);
+ __ movq(R13, Address(RSP, RAX, TIMES_4, 0)); // RAX (argument count) is Smi.
+ __ LoadTaggedClassIdMayBeSmi(RAX, R13);
// RAX: receiver's class ID as smi.
__ movq(R13, Address(R12, 0)); // First class ID (Smi) to check.
__ jmp(&test);
@@ -1301,8 +1300,8 @@
if (i > 0) {
// If not the first, load the next argument's class ID.
__ movq(RAX, FieldAddress(R10, ArgumentsDescriptor::count_offset()));
- __ movq(RAX, Address(RSP, RAX, TIMES_4, - i * kWordSize));
- __ LoadTaggedClassIdMayBeSmi(RAX, RAX);
+ __ movq(R13, Address(RSP, RAX, TIMES_4, - i * kWordSize));
+ __ LoadTaggedClassIdMayBeSmi(RAX, R13);
// RAX: next argument class ID (smi).
__ movq(R13, Address(R12, i * kWordSize));
// R13: next class ID to check (smi).
@@ -1319,8 +1318,8 @@
// Reload receiver class ID. It has not been destroyed when num_args == 1.
if (num_args > 1) {
__ movq(RAX, FieldAddress(R10, ArgumentsDescriptor::count_offset()));
- __ movq(RAX, Address(RSP, RAX, TIMES_4, 0));
- __ LoadTaggedClassIdMayBeSmi(RAX, RAX);
+ __ movq(R13, Address(RSP, RAX, TIMES_4, 0));
+ __ LoadTaggedClassIdMayBeSmi(RAX, R13);
}
const intptr_t entry_size = ICData::TestEntryLengthFor(num_args) * kWordSize;
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698