Cleanup of class id loading sequences.

runtime/vm/assembler_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/heap.h"
@@ skipping 1412 matching lines @@
 
 void Assembler::xchgq(Register dst, Register src) {
   AssemblerBuffer::EnsureCapacity ensured(&buffer_);
   Operand operand(src);
   EmitOperandREX(dst, operand, REX_W);
   EmitUint8(0x87);
   EmitOperand(dst & 7, operand);
 }
 
 
+void Assembler::cmpb(const Address& address, const Immediate& imm) {
+  AssemblerBuffer::EnsureCapacity ensured(&buffer_);
+  EmitOperandREX(7, address, REX_NONE);
+  EmitUint8(0x80);
+  EmitOperand(7, address);
+  ASSERT(imm.is_int8());
+  EmitUint8(imm.value() & 0xFF);
+}
+
+
 void Assembler::cmpl(Register reg, const Immediate& imm) {
   AssemblerBuffer::EnsureCapacity ensured(&buffer_);
   EmitRegisterREX(reg, REX_NONE);
   EmitComplex(7, Operand(reg), imm);
 }
 
 
 void Assembler::cmpl(Register reg0, Register reg1) {
   AssemblerBuffer::EnsureCapacity ensured(&buffer_);
   Operand operand(reg1);
@@ skipping 1930 matching lines @@
 }
 
 
 void Assembler::CompareClassId(Register object, intptr_t class_id) {
   LoadClassId(TMP, object);
   cmpl(TMP, Immediate(class_id));
 }
 
 
 void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
-  ASSERT(object != TMP);
-  ASSERT(result != TMP);
+  ASSERT(result != object);
 
-  // Make a copy of object since result and object can be the same register.
-  movq(TMP, object);
   // Load up a null object. We only need it so we can use LoadClassId on it in
   // the case that object is a Smi.
   LoadObject(result, Object::null_object(), PP);
   // Check if the object is a Smi.
-  testq(TMP, Immediate(kSmiTagMask));
-  // If the object *is* a Smi, load the null object into tmp. o/w leave alone.
-  cmoveq(TMP, result);
+  testq(object, Immediate(kSmiTagMask));
+  // If the object *is* a Smi, use the null object instead.
+  cmoveq(object, result);
   // Loads either the cid of the object if it isn't a Smi, or the cid of null
   // if it is a Smi, which will be ignored.
-  LoadClassId(result, TMP);
+  LoadClassId(result, object);
 
-  movq(TMP, Immediate(kSmiCid));
+  movq(object, Immediate(kSmiCid));
   // If object is a Smi, move the Smi cid into result. o/w leave alone.
-  cmoveq(result, TMP);
+  cmoveq(result, object);
   // Finally, tag the result.
   SmiTag(result);
 }
 
 
 static const char* cpu_reg_names[kNumberOfCpuRegisters] = {
   "rax", "rcx", "rdx", "rbx", "rsp", "rbp", "rsi", "rdi",
   "r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15"
 };
 
@@ skipping 11 matching lines @@
 
 
 const char* Assembler::FpuRegisterName(FpuRegister reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
   return xmm_reg_names[reg];
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64