Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 392333007: cc: Add raster tile priority queue construct perftest. (Closed)

Created:
6 years, 5 months ago by vmpstr
Modified:
6 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Add raster tile priority queue construct perftest. This patch adds a construct test for raster tile priority queue, as well as fixes up (and slightly renames) the construct and iterate perftest. Initial runs from my linux desktop: [ RUN ] TileManagerPerfTest.RasterTileQueueConstructAndIterate *RESULT tile_manager_raster_tile_queue_construct_and_iterate: 2_16= 107316.4609375 runs/s *RESULT tile_manager_raster_tile_queue_construct_and_iterate: 2_32= 54775 runs/s *RESULT tile_manager_raster_tile_queue_construct_and_iterate: 2_64= 26838 runs/s *RESULT tile_manager_raster_tile_queue_construct_and_iterate: 2_128= 12552.615234375 runs/s [ OK ] TileManagerPerfTest.RasterTileQueueConstructAndIterate (8234 ms) [ RUN ] TileManagerPerfTest.RasterTileQueueConstruct *RESULT tile_manager_raster_tile_queue_construct: 2= 1589534.25 runs/s *RESULT tile_manager_raster_tile_queue_construct: 10= 1521117.75 runs/s *RESULT tile_manager_raster_tile_queue_construct: 100= 1029156.375 runs/s [ OK ] TileManagerPerfTest.RasterTileQueueConstruct (8790 ms) R=reveman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285294

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -14 lines) Patch
M cc/resources/tile_manager_perftest.cc View 1 2 chunks +64 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vmpstr
PTAL.
6 years, 5 months ago (2014-07-21 18:58:20 UTC) #1
vmpstr
On 2014/07/21 18:58:20, vmpstr wrote: > PTAL. This depends on https://codereview.chromium.org/406543003/
6 years, 5 months ago (2014-07-21 18:58:41 UTC) #2
reveman
lgtm with nit https://codereview.chromium.org/392333007/diff/1/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/392333007/diff/1/cc/resources/tile_manager_perftest.cc#newcode364 cc/resources/tile_manager_perftest.cc:364: TEST_F(TileManagerPerfTest, RasterTileQueueConstruct) { nit: not sure ...
6 years, 5 months ago (2014-07-21 19:17:01 UTC) #3
vmpstr
https://codereview.chromium.org/392333007/diff/1/cc/resources/tile_manager_perftest.cc File cc/resources/tile_manager_perftest.cc (right): https://codereview.chromium.org/392333007/diff/1/cc/resources/tile_manager_perftest.cc#newcode364 cc/resources/tile_manager_perftest.cc:364: TEST_F(TileManagerPerfTest, RasterTileQueueConstruct) { On 2014/07/21 19:17:00, reveman wrote: > ...
6 years, 5 months ago (2014-07-21 19:29:27 UTC) #4
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-22 00:15:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/392333007/20001
6 years, 5 months ago (2014-07-22 00:19:37 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 04:01:01 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 04:02:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/172372)
6 years, 5 months ago (2014-07-22 04:02:29 UTC) #9
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-24 16:21:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/392333007/20001
6 years, 5 months ago (2014-07-24 16:22:37 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 16:33:51 UTC) #12
Message was sent while issue was closed.
Change committed as 285294

Powered by Google App Engine
This is Rietveld 408576698