Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 392333004: Drop 'WebURLRequest::setTargetType' from various content/renderer files. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Drop 'WebURLRequest::setTargetType' from various content/renderer files. 'WebURLRequest::TargetType' has been dropped in Blink in favor of 'RequestContext' and 'FrameType', matching the Fetch specification's changes, and allowing both more granularity in various Blink-side checks and more clarity around the thing that caused a request, and the frame that the request affects. This CL should have zero practical effect, as it's simply hoisting the translation work that 'WebURLRequest::setTargetType' is already doing up into the content layer to bring us one step closer to removing the concept entirely. BUG=390497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285530

Patch Set 1 #

Patch Set 2 : Compile. #

Patch Set 3 : Rebase. #

Patch Set 4 : pepper_url_loader_host #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M content/renderer/media/android/media_info_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/buffered_resource_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_url_loader_host.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Mike West
Darin, would you mind taking a look at this CL? Perhaps you could recommend someone ...
6 years, 5 months ago (2014-07-21 16:13:09 UTC) #1
Mike West
Plugin question answered itself in another CL. Jochen, could you take a look at this? ...
6 years, 5 months ago (2014-07-23 08:46:09 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 09:10:23 UTC) #3
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-23 09:21:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/392333004/40001
6 years, 5 months ago (2014-07-23 09:22:20 UTC) #5
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-23 09:37:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/392333004/60001
6 years, 5 months ago (2014-07-23 09:39:01 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 14:35:37 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 15:05:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31547)
6 years, 5 months ago (2014-07-23 15:05:17 UTC) #10
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-25 08:31:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/392333004/60001
6 years, 5 months ago (2014-07-25 08:33:01 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 08:35:04 UTC) #13
Message was sent while issue was closed.
Change committed as 285530

Powered by Google App Engine
This is Rietveld 408576698