Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 39233: Fix bug 8369 and another regression (Closed)

Created:
11 years, 9 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixing two small regressions in the Find box: 1) If the Find textfield is populated when the Find box is shown, the FindPrevious and FindNext buttons should also be enabled. (issue 8369) 2) If you search for something that is not on the page, you get "0 of 0" in red. Press Esc and Ctrl+F and the label is gone but the red background color for the label remains (no bug on file, found during testing). BUG=8369 TEST=Open about:blank in Chrome. Press Ctrl+F, search for 'e' (get 0 of 0), close the Find box, reopen the Find box. Observe 'e' is in box, it is highlighted and no red is visible. Also, FindPrevious and FindNext buttons should be enabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/views/find_bar_view.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
11 years, 9 months ago (2009-03-06 00:28:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698