[Profiles] With new-profile-management all new profiles should have default avatars.

[Profiles] With new-profile-management all new profiles should have default avatars.

In the "delete the only active profile and create a new one" case, the newly
created profile should use the placeholder avatar, and not one of the custom ones. 
The same should happen for the first run default profile.

BUG=NONE
TEST=Start Chrome with --new-profile-management. Delete all the profiles you have.
The newly created profile should use the default guest-looking avatar (which you
can check in the avatar bubble).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283635

[noms (inactive), 2014-07-16 15:56:13]

Please take a look. Thanks!

[erg, 2014-07-16 19:39:07]

https://codereview.chromium.org/392313002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/392313002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.cc:687:
cache.ChooseNameForNewProfile(avatar_index) : base::string16();
So, won't this always build new profiles with the same name/avatar?

[noms (inactive), 2014-07-16 19:41:22]

https://codereview.chromium.org/392313002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/392313002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_manager.cc:687:
cache.ChooseNameForNewProfile(avatar_index) : base::string16();
Yup. But this is only runs if you're deleting the last profile (see line 672),
and you need to re-create a new "default" profile. So yes, it will always get
the same placeholder avatar, and its name will be "Person 1" (since you only
have 1 profile)

On 2014/07/16 19:39:07, erg wrote:
> So, won't this always build new profiles with the same name/avatar?

[erg, 2014-07-16 19:47:36]

lgtm

[noms (inactive), 2014-07-16 19:52:03]

Thanks!

[noms (inactive), 2014-07-16 19:52:09]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-07-16 19:54:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/392313002/1

[commit-bot: I haz the power, 2014-07-16 20:50:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[commit-bot: I haz the power, 2014-07-17 04:12:49]

Change committed as 283635