Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 392283002: Always remove registered handlers for deleted node (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Clarifying comment. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 void Node::willBeDeletedFromDocument() 323 void Node::willBeDeletedFromDocument()
324 { 324 {
325 if (!isTreeScopeInitialized()) 325 if (!isTreeScopeInitialized())
326 return; 326 return;
327 327
328 Document& document = this->document(); 328 Document& document = this->document();
329 329
330 if (hasEventTargetData()) { 330 if (hasEventTargetData()) {
331 clearEventTargetData(); 331 clearEventTargetData();
332 document.didClearTouchEventHandlers(this); 332 document.didClearTouchEventHandlers(this);
333 if (document.frameHost())
334 document.frameHost()->eventHandlerRegistry().didRemoveAllEventHandle rs(*this);
335 } 333 }
336 334
335 if (document.frameHost())
336 document.frameHost()->eventHandlerRegistry().didRemoveAllEventHandlers(* this);
337
337 if (AXObjectCache* cache = document.existingAXObjectCache()) 338 if (AXObjectCache* cache = document.existingAXObjectCache())
338 cache->remove(this); 339 cache->remove(this);
339 340
340 document.markers().removeMarkers(this); 341 document.markers().removeMarkers(this);
341 } 342 }
342 #endif 343 #endif
343 344
344 NodeRareData* Node::rareData() const 345 NodeRareData* Node::rareData() const
345 { 346 {
346 ASSERT_WITH_SECURITY_IMPLICATION(hasRareData()); 347 ASSERT_WITH_SECURITY_IMPLICATION(hasRareData());
(...skipping 2227 matching lines...) Expand 10 before | Expand all | Expand 10 after
2574 node->showTreeForThis(); 2575 node->showTreeForThis();
2575 } 2576 }
2576 2577
2577 void showNodePath(const WebCore::Node* node) 2578 void showNodePath(const WebCore::Node* node)
2578 { 2579 {
2579 if (node) 2580 if (node)
2580 node->showNodePathForThis(); 2581 node->showNodePathForThis();
2581 } 2582 }
2582 2583
2583 #endif 2584 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698