Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 392273004: [Resources] Add the Roboto font for contextual_search_promo_source and localize strings. (Closed)

Created:
6 years, 5 months ago by Mathieu
Modified:
6 years, 5 months ago
Reviewers:
jam, Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

[Resources] Add the Roboto font for contextual_search_promo_source and localize strings. BUG=374932 TBR=jam TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284003

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : virtual #

Patch Set 4 : strings for all #

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -6 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/contextual_search/promo.css View 1 2 3 4 1 chunk +37 lines, -1 line 0 comments Download
M chrome/browser/resources/contextual_search/promo.html View 1 2 3 4 1 chunk +5 lines, -4 lines 0 comments Download
A chrome/browser/resources/contextual_search/roboto.woff View Binary file 0 comments Download
M chrome/browser/search/contextual_search_promo_source.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/search/contextual_search_promo_source.cc View 5 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
Mathieu
Hello Jered, Can you have a look at the changes in chrome/browser/search? Thanks
6 years, 5 months ago (2014-07-16 16:38:34 UTC) #1
Jered
lgtm
6 years, 5 months ago (2014-07-17 16:17:10 UTC) #2
Mathieu
Thanks. TBR jam for browser_resources.grd (I'm owner of resources/contextual_search/...)
6 years, 5 months ago (2014-07-17 16:26:23 UTC) #3
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 16:26:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/392273004/1
6 years, 5 months ago (2014-07-17 16:27:54 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 16:44:35 UTC) #6
Mathieu
The CQ bit was unchecked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 16:45:05 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 16:45:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/171187) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/160229) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-17 16:45:53 UTC) #9
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 16:56:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/392273004/20001
6 years, 5 months ago (2014-07-17 16:58:01 UTC) #11
Mathieu
The CQ bit was unchecked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 17:07:45 UTC) #12
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 17:08:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/392273004/40001
6 years, 5 months ago (2014-07-17 17:09:32 UTC) #14
Mathieu
The CQ bit was unchecked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 17:56:07 UTC) #15
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 17:58:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/392273004/60001
6 years, 5 months ago (2014-07-17 18:00:02 UTC) #17
jam
lgtm
6 years, 5 months ago (2014-07-17 18:17:27 UTC) #18
Mathieu
The CQ bit was unchecked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 19:52:25 UTC) #19
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 5 months ago (2014-07-17 21:48:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/392273004/80001
6 years, 5 months ago (2014-07-17 21:48:43 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 04:12:39 UTC) #22
Message was sent while issue was closed.
Change committed as 284003

Powered by Google App Engine
This is Rietveld 408576698