Create DispatchSourceMach to run a MACH_RECV dispatch source.

Create DispatchSourceMach to run a MACH_RECV dispatch source.

This implements RAII semantics so that when the destructor runs, the source
is cancelled and event handler blocks cannot call methods on a destructed
object.

BUG=382931
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283664

[Mark Mentovai, 2014-07-16 15:45:39]

LGTM

https://codereview.chromium.org/392273002/diff/1/sandbox/mac/dispatch_source_...
File sandbox/mac/dispatch_source_mach.h (right):

https://codereview.chromium.org/392273002/diff/1/sandbox/mac/dispatch_source_...
sandbox/mac/dispatch_source_mach.h:15: // destructed, the source will be
cancelled and it will wait for the source
I think “destruct” is an awkward verb and can usually be replaced with
“destroy,” but that’s just a personal preference.

https://codereview.chromium.org/392273002/diff/1/sandbox/mac/dispatch_source_...
sandbox/mac/dispatch_source_mach.h:43: void Cancel();
This can be private.

[Robert Sesek, 2014-07-16 19:18:17]

I also added a test, because that seemed like the right thing to do.

https://codereview.chromium.org/392273002/diff/1/sandbox/mac/dispatch_source_...
File sandbox/mac/dispatch_source_mach.h (right):

https://codereview.chromium.org/392273002/diff/1/sandbox/mac/dispatch_source_...
sandbox/mac/dispatch_source_mach.h:15: // destructed, the source will be
cancelled and it will wait for the source
On 2014/07/16 15:45:38, Mark Mentovai wrote:
> I think “destruct” is an awkward verb and can usually be replaced with
> “destroy,” but that’s just a personal preference.

Done.

https://codereview.chromium.org/392273002/diff/1/sandbox/mac/dispatch_source_...
sandbox/mac/dispatch_source_mach.h:43: void Cancel();
On 2014/07/16 15:45:38, Mark Mentovai wrote:
> This can be private.

Done.

[Mark Mentovai, 2014-07-16 20:36:15]

LGTM

[Robert Sesek, 2014-07-16 20:36:28]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-07-16 20:42:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/392273002/40001

[commit-bot: I haz the power, 2014-07-17 01:04:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[Robert Sesek, 2014-07-17 02:12:46]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-07-17 02:16:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/392273002/60001

[commit-bot: I haz the power, 2014-07-17 06:36:58]

Change committed as 283664